Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1296768
| From | Linus Walleij <linus.walleij@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put |
| Date | 2015-12-22 13:50 +0100 |
| Message-ID | <qIuy6-41F-11@gated-at.bofh.it> (permalink) |
| References | <qIbYu-zb-7@gated-at.bofh.it> <qIbYu-zb-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Dec 21, 2015 at 5:39 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > for_each_child_of_node performs an of_node_get on each iteration, so a > goto out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): Patch applied with Laurent's ACK. Geert: since I don't think you're gonna send me more pull requests before the merge window I went ahead and applied this directly, OK? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-12-21 18:00 +0100
Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Laurent Pinchart <laurent.pinchart@ideasonboard.com> - 2015-12-21 21:50 +0100
Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Linus Walleij <linus.walleij@linaro.org> - 2015-12-22 13:50 +0100
Re: [PATCH 3/5] pinctrl: sh-pfc: add missing of_node_put Geert Uytterhoeven <geert@linux-m68k.org> - 2015-12-22 14:30 +0100
csiph-web