Re: [PATCH v3] serial: 8250: add gpio support to exar

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] serial: 8250: add gpio support to exar
Date	2015-12-22 11:10 +0100
Message-ID	<qIs3h-2zy-17@gated-at.bofh.it> (permalink)
References	(3 earlier) <qHQhk-3Cr-7@gated-at.bofh.it> <qIazo-8bx-7@gated-at.bofh.it> <qIdnC-1xE-51@gated-at.bofh.it> <qImKe-7xw-9@gated-at.bofh.it> <qIrTA-2h1-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Dec 22, 2015 at 11:58:17AM +0200, Andy Shevchenko wrote:
> On Tue, Dec 22, 2015 at 6:27 AM, Sudip Mukherjee
> <sudipm.mukherjee@gmail.com> wrote:
> > On Mon, Dec 21, 2015 at 08:28:51PM +0200, Andy Shevchenko wrote:
> >> On Mon, Dec 21, 2015 at 5:19 PM, Sudip Mukherjee
> >> <sudipm.mukherjee@gmail.com> wrote:
> >>
> 
> >> There are at least two approaches:
> >>  - use 8250_pci, etc as a library (see example: 8250_mid.c)
> >>  - force 8250_pci to use external libraries in some cases (seems your approach)
> 
> Third one btw is to blow up the 8250_pci. (This actually was the main
> reason why we chose separate driver approach in our case).
> 
> >> Of course better to gather maintainer's opinion first.
> >
> > Greg, can you please give some idea here about the best way to approach...
> > I personally think, having it as a module with the minor changes that
> > Alan and Andy has suggested is the best approach.
> 
> > The only downside is
> > that the module gets loaded even if the device is not there.
> 
> How is that?

Alan explained that in https://lkml.org/lkml/2015/12/20/103

Quoting from his mail "you reference the methods in it so it will
always be dragged in".

And I wanted to verify that so I tested today morning after removing the
card from my local system and after booting I saw having 8250_gpi loaded.

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 14:30 +0100
  Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-20 15:20 +0100
    Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 15:50 +0100
      Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-20 16:10 +0100
      Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 17:50 +0100
        Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 18:20 +0100
          Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 18:30 +0100
  Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 17:50 +0100
    Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 18:30 +0100
      Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-20 18:50 +0100
      Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 18:50 +0100
        Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-21 16:30 +0100
          Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-21 19:30 +0100
            Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 05:30 +0100
              Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-22 11:00 +0100
                Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 11:10 +0100
                Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-22 11:20 +0100
                Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 11:40 +0100

csiph-web