Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1296035
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] serial: 8250: add gpio support to exar |
| Date | 2015-12-21 16:30 +0100 |
| Message-ID | <qIazo-8bx-7@gated-at.bofh.it> (permalink) |
| References | <qHMdI-17i-29@gated-at.bofh.it> <qHPlg-339-9@gated-at.bofh.it> <qHPXY-3w3-5@gated-at.bofh.it> <qHQhk-3Cr-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sun, Dec 20, 2015 at 05:42:08PM +0000, One Thousand Gnomes wrote: > > So then should I rewrite it as MFD or should it be like the way you > > suggested in the other mail to have it as bool in the Kconfig and combine > > the file with 8250_pci.c when the symbol is selected? > > Yes although I'm really not sure which is the best approach of the two. Hi Alan and Andy, I was trying like: diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index 6412f14..ec3d287 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -378,3 +378,11 @@ config SERIAL_8250_MID Selecting this option will enable handling of the extra features present on the UART found on Intel Medfield SOC and various other Intel platforms. + +config SERIAL_8250_EXAR_GPIO + bool "Support for GPIO pins on XR17V352/354/358" + depends on SERIAL_8250_PCI && GPIOLIB + select GPIO_SYSFS + help + Selecting this option will enable handling of GPIO pins present + on Exar XR17V352/354/358 chips. diff --git a/drivers/tty/serial/8250/Makefile b/drivers/tty/serial/8250/Makefile index e177f86..1d0fce0 100644 --- a/drivers/tty/serial/8250/Makefile +++ b/drivers/tty/serial/8250/Makefile @@ -28,5 +28,8 @@ obj-$(CONFIG_SERIAL_8250_MT6577) += 8250_mtk.o obj-$(CONFIG_SERIAL_8250_UNIPHIER) += 8250_uniphier.o obj-$(CONFIG_SERIAL_8250_INGENIC) += 8250_ingenic.o obj-$(CONFIG_SERIAL_8250_MID) += 8250_mid.o +obj-$(CONFIG_SERIAL_8250_EXAR_GPIO) += exar_gpio.o +exar_gpio-y := 8250_pci.o 8250_gpio.o + CFLAGS_8250_ingenic.o += -I$(srctree)/scripts/dtc/libfdt But I am getting: ERROR: "xr17v35x_gpio_exit" [drivers/tty/serial/8250/8250_pci.ko] undefined! ERROR: "xr17v35x_gpio_init" [drivers/tty/serial/8250/8250_pci.ko] undefined! I will need little hint for the Makefile, please. Its clear that i have messed up. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 14:30 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-20 15:20 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 15:50 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-20 16:10 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 17:50 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 18:20 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 18:30 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 17:50 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-20 18:30 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-20 18:50 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2015-12-20 18:50 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-21 16:30 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-21 19:30 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 05:30 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-22 11:00 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 11:10 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-22 11:20 +0100
Re: [PATCH v3] serial: 8250: add gpio support to exar Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-22 11:40 +0100
csiph-web