Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Tadeusz Struk <tadeusz.struk@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api
Date	Wed, 23 Dec 2015 16:10:02 +0100
Message-ID	<qITd8-2LA-7@gated-at.bofh.it> (permalink)
References	<qISK5-2lN-3@gated-at.bofh.it> <qIT3r-2sw-11@gated-at.bofh.it>
X-Original-To	Herbert Xu <herbert@gondor.apana.org.au>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.20,469,1444719600"; d="scan'208";a="868285009"
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, dhowells@redhat.com, linux-security-module@vger.kernel.org, linux-crypto@vger.kernel.org, zohar@linux.vnet.ibm.com
X-Original-Date	Wed, 23 Dec 2015 06:58:55 -0800
X-Original-Message-ID	<567AB6AF.4040702@intel.com>
X-Original-References	<20151223143352.5035.85876.stgit@tstruk-mobl1> <20151223145130.GA2598@gondor.apana.org.au>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1297501

Show key headers only | View raw

On 12/23/2015 06:51 AM, Herbert Xu wrote:
>> > Changes in v4:
>> > - Flatten both patches into one to avoid bisect compilation problems.
> Why is this necessary?

Because the first patch modifies the struct public_key and removes the MPIs from it,
which the code modified in the second patch still uses. If bisect only takes the first
then the build will fail on the security/integrity/digsig_asymmetric.c as reported by
kbuild test robot:

>> security/integrity/digsig_asymmetric.c:95:5: error: 'struct public_key_signature' has no member named 'nr_mpi'
     pks.nr_mpi = 1;

Thanks,
-- 
TS
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v4] crypto: KEYS: convert public key and digsig asym to the  akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2015-12-23 15:40 +0100
  Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-23 16:00 +0100
    Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2015-12-23 16:10 +0100
      Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-23 21:30 +0100
        Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2015-12-24 04:10 +0100

csiph-web