Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1297618

Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to the akcipher api
Date 2015-12-23 21:30 +0100
Message-ID <qIYcN-5Na-1@gated-at.bofh.it> (permalink)
References <qISK5-2lN-3@gated-at.bofh.it> <qIT3r-2sw-11@gated-at.bofh.it> <qITd8-2LA-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Dec 23, 2015 at 06:58:55AM -0800, Tadeusz Struk wrote:
> 
> Because the first patch modifies the struct public_key and removes the MPIs from it,
> which the code modified in the second patch still uses. If bisect only takes the first
> then the build will fail on the security/integrity/digsig_asymmetric.c as reported by
> kbuild test robot:

Why not just leave the MPIs in the structure and only remove them
by adding a third patch?

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4] crypto: KEYS: convert public key and digsig asym to the  akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2015-12-23 15:40 +0100
  Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-23 16:00 +0100
    Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2015-12-23 16:10 +0100
      Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-23 21:30 +0100
        Re: [PATCH v4] crypto: KEYS: convert public key and digsig asym to  the akcipher api Tadeusz Struk <tadeusz.struk@intel.com> - 2015-12-24 04:10 +0100

csiph-web