Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly

Path	csiph.com!goblin3!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly
Date	Tue, 22 Dec 2015 21:40:02 +0100
Message-ID	<qIBSW-e4-19@gated-at.bofh.it> (permalink)
References	<qImKe-7xw-1@gated-at.bofh.it>
X-Original-To	Chen-Yu Tsai <wens@csie.org>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6nSyB+bcl/pT7+kx"
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	56
Organization	linux.* mail to news gateway
X-Original-Cc	Mauro Carvalho Chehab <mchehab@osg.samsung.com>, Hans de Goede <hdegoede@redhat.com>, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 22 Dec 2015 21:38:53 +0100
X-Original-Message-ID	<20151222203853.GC30359@lukather>
X-Original-References	<1450758455-22945-1-git-send-email-wens@csie.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1297057

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Tue, Dec 22, 2015 at 12:27:35PM +0800, Chen-Yu Tsai wrote:
> The driver allocates the spinlock but fails to initialize it correctly.
> The kernel reports a BUG indicating bad spinlock magic when spinlock
> debugging is enabled.
> 
> Call spin_lock_init() on it to initialize it correctly.
> 
> Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver")
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>

You should probably Cc stable on this one.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly Chen-Yu Tsai <wens@csie.org> - 2015-12-22 05:30 +0100
  Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly Hans de Goede <hdegoede@redhat.com> - 2015-12-22 12:50 +0100
  Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-22 21:40 +0100

csiph-web