[PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	[PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly
Date	2015-12-22 05:30 +0100
Message-ID	<qImKe-7xw-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The driver allocates the spinlock but fails to initialize it correctly.
The kernel reports a BUG indicating bad spinlock magic when spinlock
debugging is enabled.

Call spin_lock_init() on it to initialize it correctly.

Fixes: b4e3e59fb59c ("[media] rc: add sunxi-ir driver")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
---
 drivers/media/rc/sunxi-cir.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/rc/sunxi-cir.c b/drivers/media/rc/sunxi-cir.c
index 7830aef3db45..40f77685cc4a 100644
--- a/drivers/media/rc/sunxi-cir.c
+++ b/drivers/media/rc/sunxi-cir.c
@@ -153,6 +153,8 @@ static int sunxi_ir_probe(struct platform_device *pdev)
 	if (!ir)
 		return -ENOMEM;
 
+	spin_lock_init(&ir->ir_lock);
+
 	if (of_device_is_compatible(dn, "allwinner,sun5i-a13-ir"))
 		ir->fifo_size = 64;
 	else
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly Chen-Yu Tsai <wens@csie.org> - 2015-12-22 05:30 +0100
  Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly Hans de Goede <hdegoede@redhat.com> - 2015-12-22 12:50 +0100
  Re: [PATCH] [media] rc: sunxi-cir: Initialize the spinlock properly Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-22 21:40 +0100

csiph-web