Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup()

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup()
Date	2015-12-19 01:50 +0100
Message-ID	<qHdSG-4si-21@gated-at.bofh.it> (permalink)
References	<qC6I9-7o-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 05, 2015 at 01:04:34AM +0300, Alexey Khoroshilov wrote:
> If hif_read_reg() or hif_write_reg() fail in wilc_wlan_cleanup(),
> it calls release_bus() and continues execution. But it leads to double
> release_bus() call that means double unlock of g_linux_wlan->hif_cs mutex.
> 
> The patch adds return in case of failure.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
>  drivers/staging/wilc1000/wilc_wlan.c | 2 ++
>  1 file changed, 2 insertions(+)

No longer applies to my tree, can you rebase it against staging-testing
and resend?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure  path in wilc_wlan_cleanup() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-19 01:50 +0100
  [PATCH] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2015-12-20 22:50 +0100
    Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure  path in wilc_wlan_cleanup() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-21 22:30 +0100
      [PATCH v3] staging: wilc1000: fix double mutex_unlock on failure path in wilc_wlan_cleanup() Alexey Khoroshilov <khoroshilov@ispras.ru> - 2015-12-22 18:50 +0100
    Re: [PATCH] staging: wilc1000: fix double mutex_unlock on failure  path in wilc_wlan_cleanup() Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-22 09:10 +0100

csiph-web