Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1293977

Re: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

changbin.du@intel.com writes:
> From: "Du, Changbin" <changbin.du@intel.com>
>
> Queue a request to disabled ep  doesn't make sense, and induce caller
> make mistakes.
>
> Here is a example for the android mtp gadget function driver. A mem
> corruption can happen on below senario.
> 1) On disconnect, mtp driver disable its EPs,
> 2) During send_file_work and receive_file_work, mtp queues a request
>    to ep. (The mtp driver need improve its synchronization logic!)
> 3) mtp_function_unbind is invoked and all mtp requests are freed.
> 4) when udc process the request queued on step 2, will cause kernel
>    NULL pointer dereference exception.
>
> Signed-off-by: Du, Changbin <changbin.du@intel.com>
> ---
> change from v2: igonre ep0 as it always enabled during usb session.
> change from v1: add WARN_ON_ONCE message.
> ---
>  include/linux/usb/gadget.h | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 3d583a1..0c5d9ea 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -402,6 +402,9 @@ static inline void usb_ep_free_request(struct usb_ep *ep,
>  static inline int usb_ep_queue(struct usb_ep *ep,
>  			       struct usb_request *req, gfp_t gfp_flags)
>  {
> +	if (WARN_ON_ONCE(!ep->enabled && !ep->address))

this will only trigger for a disabled ep0. Are you testing any of your
patches at all ?

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] usb: gadget: forbid queuing request to a disabled ep changbin.du@intel.com - 2015-12-14 05:00 +0100
  RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep "Du, Changbin" <changbin.du@intel.com> - 2015-12-14 11:30 +0100
    RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep Felipe Balbi <balbi@ti.com> - 2015-12-16 18:00 +0100
      RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep "Du, Changbin" <changbin.du@intel.com> - 2015-12-17 10:40 +0100
      [PATCH v3] usb: gadget: forbid queuing request to a disabled ep changbin.du@intel.com - 2015-12-17 11:10 +0100
        Re: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep Felipe Balbi <balbi@ti.com> - 2015-12-17 16:30 +0100
          RE: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep "Du, Changbin" <changbin.du@intel.com> - 2015-12-18 08:40 +0100
          [PATCH v4] usb: gadget: forbid queuing request to a disabled ep changbin.du@intel.com - 2015-12-18 08:50 +0100

csiph-web