Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1291057
| From | "Du, Changbin" <changbin.du@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep |
| Date | 2015-12-14 11:30 +0100 |
| Message-ID | <qFyye-4PE-7@gated-at.bofh.it> (permalink) |
| References | <qEdcu-Km-3@gated-at.bofh.it> <qFssO-HZ-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 3d583a1..b566a4b 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -402,6 +402,9 @@ static inline void usb_ep_free_request(struct usb_ep
> *ep,
> static inline int usb_ep_queue(struct usb_ep *ep,
> struct usb_request *req, gfp_t gfp_flags)
> {
> + if (WARN_ON_ONCE(!ep->enabled))
> + return -ESHUTDOWN;
> +
> return ep->ops->queue(ep, req, gfp_flags);
> }
>
> --
> 2.5.0
With this patch, ep0 transfer breaks. it because the 'enabled' of ep0 is not set. Ep0
is not enabled by usb_ep_enable, but in UDC driver. So there need another patch
to set ep0's flag also.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] usb: gadget: forbid queuing request to a disabled ep changbin.du@intel.com - 2015-12-14 05:00 +0100
RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep "Du, Changbin" <changbin.du@intel.com> - 2015-12-14 11:30 +0100
RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep Felipe Balbi <balbi@ti.com> - 2015-12-16 18:00 +0100
RE: [PATCH v2] usb: gadget: forbid queuing request to a disabled ep "Du, Changbin" <changbin.du@intel.com> - 2015-12-17 10:40 +0100
[PATCH v3] usb: gadget: forbid queuing request to a disabled ep changbin.du@intel.com - 2015-12-17 11:10 +0100
Re: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep Felipe Balbi <balbi@ti.com> - 2015-12-17 16:30 +0100
RE: [PATCH v3] usb: gadget: forbid queuing request to a disabled ep "Du, Changbin" <changbin.du@intel.com> - 2015-12-18 08:40 +0100
[PATCH v4] usb: gadget: forbid queuing request to a disabled ep changbin.du@intel.com - 2015-12-18 08:50 +0100
csiph-web