Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1293691

Re: rhashtable: Prevent spurious EBUSY errors on insertion

Path csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From Xin Long <lucien.xin@gmail.com>
Newsgroups linux.kernel
Subject Re: rhashtable: Prevent spurious EBUSY errors on insertion
Date Thu, 17 Dec 2015 10:10:02 +0100
Message-ID <qGCJs-5LN-1@gated-at.bofh.it> (permalink)
References <qwXvP-1JB-15@gated-at.bofh.it> <qAt6b-1Ny-17@gated-at.bofh.it> <qAtIR-2gq-1@gated-at.bofh.it> <qAtIR-2gq-15@gated-at.bofh.it> <qBBuH-53y-37@gated-at.bofh.it> <qGCq6-5pv-19@gated-at.bofh.it> <qGCq6-5pv-17@gated-at.bofh.it>
X-Original-To Herbert Xu <herbert@gondor.apana.org.au>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=kZ5o0SMbaJ5GQNsP8Js4jZfetTEgo9k8SRHAO5u5UhA=; b=jdOuhdJ4Rp2WWalVAXJ4VQ/SinKEapF5lsw2bWWXHisNTFGFteelUbehf60w4lIasJ xUN/yZPV8jJ8I0FDRQk6+T10Vt1bNkI/XwkCTE8g1FSyv7fxjWbsVaBzkMbxMv/cC5l/ vYqerRqT1T6d/n32F6UCETIms2e6OXxqm/LKaX2jGh9P0XZaTJDjfF1QgonB2lFtq7Kx tuj5/xawyd1usWqA1gfL5fP4MEyebp+t75eA38p3ZgORMxyEYmReToZwH/n3qM1+wiPX Oa1LpmjYeK5ZMpZmkZq4rnAllzvRk8/a5SJ0VPceX6Ig/cSGmIJUOamzLDjQsEwZsZkt vNEA==
MIME-Version 1.0
X-Received by 10.50.62.242 with SMTP id b18mr2288556igs.30.1450342835690; Thu, 17 Dec 2015 01:00:35 -0800 (PST)
Content-Type text/plain; charset=UTF-8
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 31
Organization linux.* mail to news gateway
X-Original-Cc Phil Sutter <phil@nwl.cc>, davem <davem@davemloft.net>, network dev <netdev@vger.kernel.org>, linux-kernel@vger.kernel.org, tgraf@suug.ch, fengguang.wu@intel.com, wfg@linux.intel.com, lkp@01.org
X-Original-Date Thu, 17 Dec 2015 17:00:35 +0800
X-Original-Message-ID <CADvbK_df=Z1re2wPUF9JCXggBzRqF=Tgt86PXV0KqBcx3VeVNA@mail.gmail.com>
X-Original-References <1448039840-11367-1-git-send-email-phil@nwl.cc> <20151130093755.GA8159@gondor.apana.org.au> <20151130101401.GA17712@orbit.nwl.cc> <20151130101859.GA8378@gondor.apana.org.au> <20151203124129.GA5505@gondor.apana.org.au> <CADvbK_cA5qaooTOE4Z2bGYs+ys17ZajSMgKDVWgctSZWJ0vjpw@mail.gmail.com> <20151217084809.GC9239@gondor.apana.org.au>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1293691

Show key headers only | View raw


On Thu, Dec 17, 2015 at 4:48 PM, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Thu, Dec 17, 2015 at 04:46:00PM +0800, Xin Long wrote:
>>
>> sorry for late test, but unfortunately, my case with rhashtalbe still
>> return EBUSY.
>> I added some debug code in rhashtable_insert_rehash(), and found:
>> *future_tbl is null*
>>
>> fail:
>>         /* Do not fail the insert if someone else did a rehash. */
>>         if (likely(rcu_dereference_raw(tbl->future_tbl))) {
>>                 printk("future_tbl is there\n");
>>                 return 0;
>>         } else {
>>                 printk("future_tbl is null\n");
>>         }
>>
>> any idea why ?
>
> That's presumably because you got a genuine double rehash.
>
> Until you post your code we can't really help you.
>
i wish i could , but my codes is a big patch for sctp, and this issue
happens in a special stress test based on this patch.
im trying to think how i can show you. :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: rhashtable: Prevent spurious EBUSY errors on insertion Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-17 09:50 +0100
  Re: rhashtable: Prevent spurious EBUSY errors on insertion Xin Long <lucien.xin@gmail.com> - 2015-12-17 10:10 +0100
    Re: rhashtable: Prevent spurious EBUSY errors on insertion Xin Long <lucien.xin@gmail.com> - 2015-12-17 17:10 +0100
      Re: rhashtable: Prevent spurious EBUSY errors on insertion Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-18 03:30 +0100
        Re: rhashtable: Prevent spurious EBUSY errors on insertion Xin Long <lucien.xin@gmail.com> - 2015-12-18 09:20 +0100
    Re: rhashtable: Prevent spurious EBUSY errors on insertion David Miller <davem@davemloft.net> - 2015-12-17 18:10 +0100

csiph-web