Re: rhashtable: Prevent spurious EBUSY errors on insertion

From	Xin Long <lucien.xin@gmail.com>
Newsgroups	linux.kernel
Subject	Re: rhashtable: Prevent spurious EBUSY errors on insertion
Date	2015-12-18 09:20 +0100
Message-ID	<qGYqB-379-15@gated-at.bofh.it> (permalink)
References	(5 earlier) <qGCq6-5pv-19@gated-at.bofh.it> <qGCq6-5pv-17@gated-at.bofh.it> <qGCJs-5LN-1@gated-at.bofh.it> <qGJhU-1Gz-25@gated-at.bofh.it> <qGSXU-7WI-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Dec 18, 2015 at 10:26 AM, Herbert Xu
<herbert@gondor.apana.org.au> wrote:
> On Fri, Dec 18, 2015 at 12:07:08AM +0800, Xin Long wrote:
>>
>> I'm just wondering, why do not we handle the genuine double rehash
>> issue inside rhashtable? i mean it's just a temporary error that a
>> simple retry may fix it.
>
> Because a double rehash means that someone has cracked your hash
> function and there is no point in trying anymore.

ok, get your point, is it possible to be triggered by some cases under
a big stress insertion, but they are all legal cases. like we use rhash in
nftables, if there are a big batch sets to insert, may this issue happen?

>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: rhashtable: Prevent spurious EBUSY errors on insertion Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-17 09:50 +0100
  Re: rhashtable: Prevent spurious EBUSY errors on insertion Xin Long <lucien.xin@gmail.com> - 2015-12-17 10:10 +0100
    Re: rhashtable: Prevent spurious EBUSY errors on insertion Xin Long <lucien.xin@gmail.com> - 2015-12-17 17:10 +0100
      Re: rhashtable: Prevent spurious EBUSY errors on insertion Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-18 03:30 +0100
        Re: rhashtable: Prevent spurious EBUSY errors on insertion Xin Long <lucien.xin@gmail.com> - 2015-12-18 09:20 +0100
    Re: rhashtable: Prevent spurious EBUSY errors on insertion David Miller <davem@davemloft.net> - 2015-12-17 18:10 +0100

csiph-web