Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1292431
| From | Joe Perches <joe@perches.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions |
| Date | 2015-12-15 19:20 +0100 |
| Message-ID | <qG2mB-7LE-11@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <qFflU-CN-5@gated-at.bofh.it> <qFYM2-5hd-23@gated-at.bofh.it> <qFZ5o-5o7-13@gated-at.bofh.it> <qFZoJ-5LF-13@gated-at.bofh.it> <qG1Tz-7mv-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 2015-12-15 at 20:48 +0300, Dan Carpenter wrote:
> On Tue, Dec 15, 2015 at 07:02:31AM -0800, Joe Perches wrote:
> > This is the original code:
> >
> > result = foo();
> > if (result)
> > goto label;
> >
> > result = bar();
> > if (result)
> > goto label;
> >
> > result = baz();
> > if (result)
> > goto label;
> >
> > label:
> > go on...
> >
>
> No. There is no test. The original code looks like:
>
> result = foo();
> if (result)
> goto out;
> result = baz();
> goto out;
> out:
> go on..
>
> regards,
> dan carpenter
Here is the original code:
---------------------
/* Copy hsm_progress struct */
req_hpk = req_capsule_client_get(&req->rq_pill, &RMF_MDS_HSM_PROGRESS);
if (req_hpk == NULL) {
rc = -EPROTO;
goto out;
}
*req_hpk = *hpk;
req_hpk->hpk_errval = lustre_errno_hton(hpk->hpk_errval);
ptlrpc_request_set_replen(req);
rc = mdc_queue_wait(req);
goto out;
out:
ptlrpc_req_finished(req);
return rc;
}
---------------------
I think if the last goto out; is to be removed,
then it should be replaced by a blank line.
It separates the last operation block from the return.
cheers, Joe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] staging-Lustre: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 14:50 +0100
[PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 15:00 +0100
Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-14 08:00 +0100
Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-14 10:10 +0100
Re: [PATCH 2/7] staging: lustre: Rename a jump label for ptlrpc_req_finished() calls Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-14 10:40 +0100
Re: staging: lustre: Rename a jump label for ptlrpc_req_finished() calls SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-14 11:10 +0100
[PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 15:00 +0100
Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions Joe Perches <joe@perches.com> - 2015-12-15 15:30 +0100
Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-15 15:50 +0100
Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions Joe Perches <joe@perches.com> - 2015-12-15 16:10 +0100
Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-15 18:50 +0100
Re: [PATCH 1/7] staging: lustre: Delete unnecessary goto statements in six functions Joe Perches <joe@perches.com> - 2015-12-15 19:20 +0100
Re: staging: lustre: Delete unnecessary goto statements in six functions SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-15 19:30 +0100
Re: staging: lustre: Delete unnecessary goto statements in six functions Joe Perches <joe@perches.com> - 2015-12-15 19:40 +0100
Re: staging: lustre: Delete unnecessary goto statements in six functions SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-15 20:00 +0100
Re: staging: lustre: Delete unnecessary goto statements in six functions Joe Perches <joe@perches.com> - 2015-12-15 20:00 +0100
Re: staging: lustre: Delete unnecessary goto statements in six functions SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-15 19:10 +0100
Re: staging: lustre: Delete unnecessary goto statements in six functions Joe Perches <joe@perches.com> - 2015-12-15 19:30 +0100
[PATCH 3/7] staging: lustre: Rename a jump label for a kfree(key) call SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 15:00 +0100
[PATCH 6/7] staging: lustre: A few checks less in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 15:00 +0100
[PATCH 5/7] staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 15:00 +0100
Re: [PATCH 5/7] staging: lustre: Less checks in mgc_process_recover_log() after error detection Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-14 12:10 +0100
Re: [PATCH 5/7] staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-14 13:10 +0100
Re: [PATCH 5/7] staging: lustre: Less checks in mgc_process_recover_log() after error detection Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-14 13:40 +0100
Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-14 13:50 +0100
Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-14 15:00 +0100
Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-14 18:50 +0100
Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-15 12:50 +0100
Re: staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-15 16:10 +0100
[PATCH 4/7] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 15:00 +0100
[PATCH 7/7] staging: lustre: Rename a jump label for module_put() calls SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-13 15:10 +0100
[PATCH v2 0/4] staging-Lustre: Fine-tuning for some function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 20:10 +0100
[PATCH v2 1/4] staging: lustre: Delete unnecessary goto statements in six functions SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 20:10 +0100
[PATCH v2 4/4] staging: lustre: Fix a jump label position in osc_get_info() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 20:20 +0100
[PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 20:20 +0100
Re: [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-22 00:50 +0100
Re: [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-22 08:20 +0100
Re: [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection Dan Carpenter <dan.carpenter@oracle.com> - 2015-12-22 09:10 +0100
[PATCH v2 2/4] staging: lustre: Delete an unnecessary variable initialisation in mgc_process_recover_log() SF Markus Elfring <elfring@users.sourceforge.net> - 2015-12-21 20:20 +0100
csiph-web