Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

From	Chris Mason <clm@fb.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR
Date	2015-12-13 17:00 +0100
Message-ID	<qFhe2-1Oi-5@gated-at.bofh.it> (permalink)
References	<qEVdw-4sK-11@gated-at.bofh.it> <qEXfj-5Kv-5@gated-at.bofh.it> <qEYl5-6qE-49@gated-at.bofh.it> <qFbBD-6Gz-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Dec 13, 2015 at 10:50:01AM +0100, Peter Zijlstra wrote:
> On Sat, Dec 12, 2015 at 11:41:26AM -0800, Linus Torvalds wrote:
> > It looks like PeterZ's pending patch should fix this, by passing in
> > the proper TASK_UNINTERRUPTIBLE to the bit_wait_io function, and going
> > back to signal_pending_state(). PeterZ, did I follow the history of
> > this correctly?
> 
> Yes. I made a right mess of things with my 'fix'.

Our two fixes together made it overnight.  So at least for the
lock_page() case things are extra super fixed.

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Chris Mason <clm@fb.com> - 2015-12-12 17:30 +0100
  Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-12 19:40 +0100
    Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-12 20:50 +0100
      Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-13 01:10 +0100
        Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Dave Jones <dsj@fb.com> - 2015-12-14 19:40 +0100
          Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-14 21:10 +0100
          Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-15 01:10 +0100
      Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Peter Zijlstra <peterz@infradead.org> - 2015-12-13 11:00 +0100
        Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-13 17:00 +0100
        Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-13 22:00 +0100
          Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Peter Zijlstra <peterz@infradead.org> - 2015-12-13 22:20 +0100

csiph-web