Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR

From	Linus Torvalds <torvalds@linux-foundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR
Date	2015-12-12 19:40 +0100
Message-ID	<qEXfj-5Kv-5@gated-at.bofh.it> (permalink)
References	<qEVdw-4sK-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 12, 2015 at 8:23 AM, Chris Mason <clm@fb.com> wrote:
> We have two reports of frequent crashes in btrfs where asserts in
> clear_page_dirty_for_io() were triggering on missing page locks.
>
> The crashes were much easier to trigger when processes were catching
> ctrl-c's, and after much debugging it really looked like lock_page was a
> noop.

Hmm. PeterZ has another patch for wait_ob_bit signal handling pending,
but I *think* that one only affects the "killable()" case.

Peter, did that patch also handle just plain "lock_page()" case?

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Chris Mason <clm@fb.com> - 2015-12-12 17:30 +0100
  Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-12 19:40 +0100
    Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-12 20:50 +0100
      Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-13 01:10 +0100
        Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Dave Jones <dsj@fb.com> - 2015-12-14 19:40 +0100
          Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-14 21:10 +0100
          Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-15 01:10 +0100
      Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Peter Zijlstra <peterz@infradead.org> - 2015-12-13 11:00 +0100
        Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Chris Mason <clm@fb.com> - 2015-12-13 17:00 +0100
        Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns -EINTR Linus Torvalds <torvalds@linux-foundation.org> - 2015-12-13 22:00 +0100
          Re: [PATCH] lock_page() doesn't lock if __wait_on_bit_lock returns  -EINTR Peter Zijlstra <peterz@infradead.org> - 2015-12-13 22:20 +0100

csiph-web