Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291939

Re: [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf

Show all headers | View raw

This patch contains a problem.

On 2015/12/15 11:35, Wang Nan wrote:
> From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
>
> perf build is currently (v4.4-rc5) broken on powerpc:
>
> bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support
> your arch.
>   #  error __NR_bpf not defined. libbpf does not support your arch.
>      ^
>
> Fix this by including tools/perf/config/Makefile.arch for the proper
> $ARCH macro. While at it, remove redundant LP64 macro definition.
>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
> Cc: Jiri Olsa <jolsa@redhat.com>
> Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
> ---
>   tools/lib/bpf/Makefile | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index 636e3dd..3d34a8c 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -31,7 +31,8 @@ INSTALL = install
>   DESTDIR ?=
>   DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
>   
> -LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
> +include $(srctree)/tools/scripts/Makefile.arch
> +

Here we depend on $(srctree), but libbpf's Makefile doesn't automatically
detect it. Directly 'make' in libbpf directory causes an error.

Will post a v4 for it.

Thank you.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-14 12:00 +0100
  [PATCH] tools lib bpf: Support libbpf on PowerPC Wang Nan <wangnan0@huawei.com> - 2015-12-14 12:40 +0100
  Re: [PATCH] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-14 13:00 +0100
    Re: [PATCH] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-14 16:20 +0100
  [PATCH v2] tools lib bpf: Support libbpf on PowerPC Wang Nan <wangnan0@huawei.com> - 2015-12-14 13:00 +0100
    Re: [PATCH v2] tools lib bpf: Support libbpf on PowerPC "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-14 16:50 +0100
  [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
  [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
    [PATCH v3 1/3] perf tools: Fix PowerPC native building Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
    [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
      [PATCH v4] perf: bpf: Fix build breakage due to libbpf Wang Nan <wangnan0@huawei.com> - 2015-12-15 10:00 +0100
        Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-15 12:50 +0100
          Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-16 20:50 +0100
            Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 02:40 +0100
              Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-17 06:10 +0100
                Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-17 13:20 +0100
      Re: [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-15 10:00 +0100
    Re: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to  libbpf Jiri Olsa <jolsa@redhat.com> - 2015-12-15 09:10 +0100
    Re: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to  libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-15 12:40 +0100

csiph-web