Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291938

[PATCH v4] perf: bpf: Fix build breakage due to libbpf

Show all headers | View raw

From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>

perf build is currently (v4.4-rc5) broken on powerpc:

bpf.c:28:4: error: #error __NR_bpf not defined. libbpf does not support
your arch.
 #  error __NR_bpf not defined. libbpf does not support your arch.
    ^

Fix this by including tools/scripts/Makefile.arch for the proper
$ARCH macro. While at it, remove redundant LP64 macro definition.

Also, since libbpf require $(srctree) now, detect the path of
srctree like perf.

Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
---

v3 -> v4: Add srctree detector code so directly run 'make' in libbpf
          directory would not cause error.

---
 tools/lib/bpf/Makefile | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
index 636e3dd..0b6e013 100644
--- a/tools/lib/bpf/Makefile
+++ b/tools/lib/bpf/Makefile
@@ -6,6 +6,12 @@ BPF_EXTRAVERSION = 1
 
 MAKEFLAGS += --no-print-directory
 
+ifeq ($(srctree),)
+srctree := $(patsubst %/,%,$(dir $(shell pwd)))
+srctree := $(patsubst %/,%,$(dir $(srctree)))
+srctree := $(patsubst %/,%,$(dir $(srctree)))
+#$(info Determined 'srctree' to be $(srctree))
+endif
 
 # Makefiles suck: This macro sets a default value of $(2) for the
 # variable named by $(1), unless the variable has been set by
@@ -31,7 +37,8 @@ INSTALL = install
 DESTDIR ?=
 DESTDIR_SQ = '$(subst ','\'',$(DESTDIR))'
 
-LP64 := $(shell echo __LP64__ | ${CC} ${CFLAGS} -E -x c - | tail -n 1)
+include $(srctree)/tools/scripts/Makefile.arch
+
 ifeq ($(LP64), 1)
   libdir_relative = lib64
 else
-- 
1.8.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-14 12:00 +0100
  [PATCH] tools lib bpf: Support libbpf on PowerPC Wang Nan <wangnan0@huawei.com> - 2015-12-14 12:40 +0100
  Re: [PATCH] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-14 13:00 +0100
    Re: [PATCH] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-14 16:20 +0100
  [PATCH v2] tools lib bpf: Support libbpf on PowerPC Wang Nan <wangnan0@huawei.com> - 2015-12-14 13:00 +0100
    Re: [PATCH v2] tools lib bpf: Support libbpf on PowerPC "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-14 16:50 +0100
  [PATCH v3 2/3] tools: Move Makefile.arch from perf/config to tools/scripts Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
  [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to libbpf Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
    [PATCH v3 1/3] perf tools: Fix PowerPC native building Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
    [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf Wang Nan <wangnan0@huawei.com> - 2015-12-15 04:40 +0100
      [PATCH v4] perf: bpf: Fix build breakage due to libbpf Wang Nan <wangnan0@huawei.com> - 2015-12-15 10:00 +0100
        Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-15 12:50 +0100
          Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-16 20:50 +0100
            Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-17 02:40 +0100
              Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-17 06:10 +0100
                Re: [PATCH v4] perf: bpf: Fix build breakage due to libbpf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-17 13:20 +0100
      Re: [PATCH v3 3/3] perf: bpf: Fix build breakage due to libbpf "Wangnan (F)" <wangnan0@huawei.com> - 2015-12-15 10:00 +0100
    Re: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to  libbpf Jiri Olsa <jolsa@redhat.com> - 2015-12-15 09:10 +0100
    Re: [PATCH v3 0/3] perf build: PowerPC: Fix build breakage due to  libbpf "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com> - 2015-12-15 12:40 +0100

csiph-web