Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1291293

[PATCH 2/3] Add missing braces to if statement

From Markus Trippelsdorf <markus@trippelsdorf.de>
Newsgroups linux.kernel
Subject [PATCH 2/3] Add missing braces to if statement
Date 2015-12-14 16:50 +0100
Message-ID <qFDxU-83l-11@gated-at.bofh.it> (permalink)
References <qEWMi-5yY-1@gated-at.bofh.it> <qFyRB-4Xv-39@gated-at.bofh.it> <qFD4T-7Rv-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Add missing braces to if statement.

The issue was pointed out by gcc-6's -Wmisleading-indentation.

Acked-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>

diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index d4d7cc27252f..718bd46d47fa 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -755,11 +755,11 @@ static int annotate_browser__run(struct annotate_browser *browser,
 				nd = browser->curr_hot;
 			break;
 		case K_UNTAB:
-			if (nd != NULL)
+			if (nd != NULL) {
 				nd = rb_next(nd);
 				if (nd == NULL)
 					nd = rb_first(&browser->entries);
-			else
+			} else
 				nd = browser->curr_hot;
 			break;
 		case K_F1:
-- 
Markus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] Fix misleading indentation issues in perf Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-12 19:10 +0100
  Re: [PATCH] Fix misleading indentation issues in perf Ingo Molnar <mingo@kernel.org> - 2015-12-14 09:30 +0100
  Re: [PATCH] Fix misleading indentation issues in perf Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-14 11:50 +0100
    Re: [PATCH] Fix misleading indentation issues in perf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 16:20 +0100
      [PATCH 3/3] Fix misleadingly indented assignment (whitespace) Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-14 16:50 +0100
      [PATCH 2/3] Add missing braces to if statement Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-14 16:50 +0100
      [PATCH 1/3] Remove wrong semicolon in while loop Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-14 16:50 +0100
        Re: [PATCH 1/3] Remove wrong semicolon in while loop Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 19:00 +0100

csiph-web