Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1291263

Re: [PATCH] Fix misleading indentation issues in perf

Show all headers | View raw

Em Mon, Dec 14, 2015 at 10:46:07AM +0000, Matt Fleming escreveu:
> On Sat, 12 Dec, at 07:07:02PM, Markus Trippelsdorf wrote:
> > perf doesn't build with gcc-6 because of several misleading-indentation
> > warnings, e.g.:
> > 
> > arch/x86/tests/intel-cqm.c: In function ‘spawn’:
> > arch/x86/tests/intel-cqm.c:21:3: error: statement is indented as if it were guarded by... [-Werror=misleading-indentation]
> >    sleep(5);
> >    ^~~~~
> > 
> > arch/x86/tests/intel-cqm.c:20:2: note: ...this ‘while’ clause, but it is not
> >   while(1);
> >   ^~~~~
> > 
> > Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
> > 
> > diff --git a/tools/perf/arch/x86/tests/intel-cqm.c b/tools/perf/arch/x86/tests/intel-cqm.c
> > index d28c1b6a3b54..fa5d17af88b7 100644
> > --- a/tools/perf/arch/x86/tests/intel-cqm.c
> > +++ b/tools/perf/arch/x86/tests/intel-cqm.c
> > @@ -17,7 +17,7 @@ static pid_t spawn(void)
> >  	if (pid)
> >  		return pid;
> >  
> > -	while(1);
> > +	while(1)
> >  		sleep(5);
> >  	return 0;
> >  }
> 
> Whoops. Good catch.
> 
> Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

So, Markus, can you split this in three patches, stating that in some
cases its just cosmetic stuff while in others really a bug got fixed,
adding the Reviewed-by:  tag for the cqm one? And acked-by for all, from
Ingo?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] Fix misleading indentation issues in perf Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-12 19:10 +0100
  Re: [PATCH] Fix misleading indentation issues in perf Ingo Molnar <mingo@kernel.org> - 2015-12-14 09:30 +0100
  Re: [PATCH] Fix misleading indentation issues in perf Matt Fleming <matt@codeblueprint.co.uk> - 2015-12-14 11:50 +0100
    Re: [PATCH] Fix misleading indentation issues in perf Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 16:20 +0100
      [PATCH 3/3] Fix misleadingly indented assignment (whitespace) Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-14 16:50 +0100
      [PATCH 2/3] Add missing braces to if statement Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-14 16:50 +0100
      [PATCH 1/3] Remove wrong semicolon in while loop Markus Trippelsdorf <markus@trippelsdorf.de> - 2015-12-14 16:50 +0100
        Re: [PATCH 1/3] Remove wrong semicolon in while loop Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-12-14 19:00 +0100

csiph-web