Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties

From	Krzysztof Kozlowski <k.kozlowski@samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties
Date	2015-12-11 05:10 +0100
Message-ID	<qEnbQ-7u0-19@gated-at.bofh.it> (permalink)
References	<qEcT7-Dg-7@gated-at.bofh.it> <qEcT7-Dg-11@gated-at.bofh.it> <qEmpr-6W9-7@gated-at.bofh.it> <qEmz9-6ZR-35@gated-at.bofh.it> <qEmIN-73Z-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11.12.2015 12:32, Viresh Kumar wrote:
> On 11-12-15, 00:25, Javier Martinez Canillas wrote:
>> The problem is that the big and LITTLE cores have different ordering per SoCs:
>>
>> - Exynos5420 and Exynos5800: cpu0-3 (Cortex-A15) and cpu4-7 (Coretx-A7)
>> - Exynos5422: cpu0-3 (Cortex-A7) and cpu4-7 (Cortex-A15)
>>
>> So the OPP tables are set in this DTSI file, to prevent the OPP tables
>> in the Exynos5422 to be inverted for the cluster 0 and 1.
> 
> Oh dude, that's really *ugly*. :)
> 
> Reusing files/definitions is fine to the point where things are
> readable. But you have screwed it up so very badly.
> 
> Over that, why can't you keep cpu0-3 as A7 and 4-7 as a15 for all the
> cases? The only worrying thing for you should be that CPU0 within the
> kenrel should be controllable, right? i.e. you want a A15 to boot 5800
> and A7 to boot 5422.
> 
> If yes, than you could have kept the CPUs in 5422 as:
> 0-3: A7
> 4-7: A15
> 
> and in 5420 as:
> 4-7: A15
> 0-3: A7
> 
> Wouldnt' that work ?

It wasn't working like this. The cpu0 got the index from booting cpu, so
on 5420 cpu0 was A15 and on 5422 it was A7.

Maybe I am not aware of some changes recently in the kernel but how do
you want to assign the booting CPU proper number (not CPU0)?

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-10 18:10 +0100
  Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 02:20 +0100
  Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 04:20 +0100
    Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Javier Martinez Canillas <javier@osg.samsung.com> - 2015-12-11 04:30 +0100
      Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 04:40 +0100
        Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 05:10 +0100
          Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 05:20 +0100
            Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 05:40 +0100
              Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Javier Martinez Canillas <javier@osg.samsung.com> - 2015-12-11 06:00 +0100
                Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 06:30 +0100
                Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 06:50 +0100
              Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 06:00 +0100
          Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 05:20 +0100
  Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 05:40 +0100

csiph-web