Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1289139
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties |
| Date | 2015-12-11 05:40 +0100 |
| Message-ID | <qEnES-7Eq-11@gated-at.bofh.it> (permalink) |
| References | (3 earlier) <qEmz9-6ZR-35@gated-at.bofh.it> <qEmIN-73Z-5@gated-at.bofh.it> <qEnbQ-7u0-19@gated-at.bofh.it> <qEnlw-7xm-19@gated-at.bofh.it> <qEnlv-7xm-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 11-12-15, 13:18, Krzysztof Kozlowski wrote:
> We had such configuration before (before df09df6f9ac3). I don't see any
> benefit in what you described. Where is the "thing" to be fixed? It is
> mixed up. The contiguous ordering is easier to read and more natural.
This is what you are doing today (keeping on one CPU per cluster to
simplify it):
cpu0: cpu@0 {
device_type = "cpu";
compatible = "arm,cortex-a15";
reg = <0x0>;
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
};
cpu4: cpu@100 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x100>;
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
};
Then you overwrite it with:
&cpu0 {
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0x100>;
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
};
&cpu4 {
device_type = "cpu";
compatible = "arm,cortex-a15";
reg = <0x0>;
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
};
Don't you think this isn't the right way of solving problems?
The DT overwrite feature isn't there to do such kind of stuff, though
it doesn't stop you from doing that.
Either you should keep separate paths for both the SoCs, or can solve
it the way I suggested earlier.
This came up because in the current series you are doing this:
cpu0: cpu@0 {
compatible = "arm,cortex-a15";
operating-points-v2 = <&cpu0_opp_table>;
};
cpu4: cpu@100 {
device_type = "cpu";
compatible = "arm,cortex-a7";
operating-points-v2 = <&cpu1_opp_table>;
};
Then you overwrite it with:
&cpu0 {
compatible = "arm,cortex-a7";
operating-points-v2 = <&cpu1_opp_table>;
};
&cpu4 {
compatible = "arm,cortex-a15";
operating-points-v2 = <&cpu0_opp_table>;
};
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> - 2015-12-10 18:10 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 02:20 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 04:20 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Javier Martinez Canillas <javier@osg.samsung.com> - 2015-12-11 04:30 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 04:40 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 05:10 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 05:20 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 05:40 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Javier Martinez Canillas <javier@osg.samsung.com> - 2015-12-11 06:00 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 06:30 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 06:50 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-12-11 06:00 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 05:20 +0100
Re: [PATCH v5 3/7] ARM: dts: Exynos542x/5800: add CPU OPP properties Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-11 05:40 +0100
csiph-web