Re: [PATCH] regmap: cache: Add warning info for the cache check

From	Xiubo Li <lixiubo@cmss.chinamobile.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regmap: cache: Add warning info for the cache check
Date	2015-12-11 02:20 +0100
Message-ID	<qEkxk-5EV-15@gated-at.bofh.it> (permalink)
References	<qDZsR-8qg-5@gated-at.bofh.it> <qE8Pw-6ig-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 10/12/2015 20:45, Charles Keepax wrote:
> On Thu, Dec 10, 2015 at 10:40:53AM +0800, Xiubo Li wrote:
>> If there is no cache used for the drivers, the register drfaults
> s/drfaults/defaults/
Yes，Thanks.


>> are not need any more. This patch will check this and print a
>> warning.
>>
>> Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
>> ---
>>   drivers/base/regmap/regcache.c | 12 ++++++++----
>>   1 file changed, 8 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
>> index 1c0210a..bdcd401 100644
>> --- a/drivers/base/regmap/regcache.c
>> +++ b/drivers/base/regmap/regcache.c
>> @@ -100,15 +100,19 @@ int regcache_init(struct regmap *map, const struct regmap_config *config)
>>   	int i;
>>   	void *tmp_buf;
>>   
>> -	for (i = 0; i < config->num_reg_defaults; i++)
>> -		if (config->reg_defaults[i].reg % map->reg_stride)
>> -			return -EINVAL;
>> -
>>   	if (map->cache_type == REGCACHE_NONE) {
>> +		if (config->num_reg_defaults)
>> +			dev_warn(map->dev,
>> +				 "No cache used with register defualts set!\n");
> s/defualts/defaults/
See the next version.


Thanks,

BRs

Xiubo

> Thanks,
> Charles



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] regmap: cache: Add warning info for the cache check Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-10 03:50 +0100
  Re: [PATCH] regmap: cache: Add warning info for the cache check Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-12-10 13:50 +0100
    Re: [PATCH] regmap: cache: Add warning info for the cache check Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-11 02:20 +0100

csiph-web