Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1288150

[PATCH] regmap: cache: Add warning info for the cache check

Show all headers | View raw

If there is no cache used for the drivers, the register drfaults
are not need any more. This patch will check this and print a
warning.

Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
---
 drivers/base/regmap/regcache.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
index 1c0210a..bdcd401 100644
--- a/drivers/base/regmap/regcache.c
+++ b/drivers/base/regmap/regcache.c
@@ -100,15 +100,19 @@ int regcache_init(struct regmap *map, const struct regmap_config *config)
 	int i;
 	void *tmp_buf;
 
-	for (i = 0; i < config->num_reg_defaults; i++)
-		if (config->reg_defaults[i].reg % map->reg_stride)
-			return -EINVAL;
-
 	if (map->cache_type == REGCACHE_NONE) {
+		if (config->num_reg_defaults)
+			dev_warn(map->dev,
+				 "No cache used with register defualts set!\n");
+
 		map->cache_bypass = true;
 		return 0;
 	}
 
+	for (i = 0; i < config->num_reg_defaults; i++)
+		if (config->reg_defaults[i].reg % map->reg_stride)
+			return -EINVAL;
+
 	for (i = 0; i < ARRAY_SIZE(cache_types); i++)
 		if (cache_types[i]->type == map->cache_type)
 			break;
-- 
1.8.3.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] regmap: cache: Add warning info for the cache check Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-10 03:50 +0100
  Re: [PATCH] regmap: cache: Add warning info for the cache check Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-12-10 13:50 +0100
    Re: [PATCH] regmap: cache: Add warning info for the cache check Xiubo Li <lixiubo@cmss.chinamobile.com> - 2015-12-11 02:20 +0100

csiph-web