Re: [PATCH v5] sun4i-codec: add inputs

From	Danny Milosavljevic <dannym@scratchpost.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5] sun4i-codec: add inputs
Date	2015-12-10 22:00 +0100
Message-ID	<qEgtI-2KO-17@gated-at.bofh.it> (permalink)
References	<qDh8t-5hA-5@gated-at.bofh.it> <qEdFx-VS-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Maxime,

On Thu, 10 Dec 2015 18:54:20 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
> > +	SOC_DAPM_SINGLE("Mic1-In Playback Switch", SUN4I_CODEC_DAC_ACTL,
> > +			SUN4I_CODEC_DAC_ACTL_MIC1RS, 1, 0),
> > +	SOC_DAPM_SINGLE("Mic2-In Playback Switch", SUN4I_CODEC_DAC_ACTL,
> > +			SUN4I_CODEC_DAC_ACTL_MIC2RS, 1, 0),
> >  };
> 
> Do we need the -In part of FM, Mic1 and Mic2?

For consistency to what's in linux-sunxi.git, I will remove the "-In" from 
the Mic names in v7.

For FM, do we? I don't know. Are there ALSA devices which output to FM?

> Mic1 is already defined a few lines above.
> And you have the Mixers routes a bit above too.

Aha, Mic1 is there in <https://github.com/linux-sunxi/linux-sunxi.git> 
branch "sunxi-next".
In <git://git.kernel.org/pub/scm/linux/kernel/git/mripard/linux.git> 
branch "sunxi/for-next", it's not there. 
This patch is for the latter.

I'm currently rebasing on the former, but it will take some time. 
The differences between these driver versions are:
- Mic1 Preamplifier is registered as PGA instead of switch in the former.
- Mic1 is already an input in the former.
- VMIC is handled in the former.
- ADC Capturing support exists in the former.
That's it.

I'll retest a patch based on the former...

> [global mutation]
> We'll need to fix that, see the other discussion.

Yeah, I think I found a nicer way to do it in v6.

Thanks,
   Danny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v5] sun4i-codec: add inputs Danny Milosavljevic <dannym@scratchpost.org> - 2015-12-08 04:30 +0100
  Re: [PATCH v5] sun4i-codec: add inputs Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-12-10 19:00 +0100
    Re: [PATCH v5] sun4i-codec: add inputs Danny Milosavljevic <dannym@scratchpost.org> - 2015-12-10 22:00 +0100
      Re: [PATCH v5] sun4i-codec: add inputs Chen-Yu Tsai <wens@csie.org> - 2015-12-11 03:50 +0100

csiph-web