Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

Path	csiph.com!au2pb.net!2.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC
Date	Thu, 10 Dec 2015 18:40:04 +0100
Message-ID	<qEdmc-OR-71@gated-at.bofh.it> (permalink)
References	<qwfl8-6tM-5@gated-at.bofh.it> <qwfl8-6tM-21@gated-at.bofh.it> <qAs0q-17U-25@gated-at.bofh.it> <qAZ61-5u6-3@gated-at.bofh.it>
X-Original-To	"Andrew F. Davis" <afd@ti.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=o8X9gXrwEHQzXT3lCcW0kiMSb/jeIR7hzvQ4k3N2mOI=; b=z+31DLwXDmWX5PlO6gfDJZV5NXcRTjel6FXLgRWFHvdsDTvgWfOpuRBzql5ZtckBpR IrxtO7cLMcnKGLrDysyQWnzxOTSLBYWPNebBYXIRqZsVrh/m6N/QyqZcML6Xi1f0VkK4 SDQxELM9Zr29ZDsopelIfwtvX6v+6RIpAlyD/hk9nf0hGCtM74xtzjmAp5WeXbB+nLPT gsBZoR3rhXhlZdq7eA5d7dDlGcoJl3Lwauodchs8ndbzFszURk8TDUToIQkH9soJWBly b4WfdsE1KKjnXPflQwfXcOXWAOM07ic/p0uZMn22aIZ5YZeC0Z+DJCs2p+HVYfArXd3i CgXg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=o8X9gXrwEHQzXT3lCcW0kiMSb/jeIR7hzvQ4k3N2mOI=; b=faIWNosp0hrZ3RYuB0EDuqDijPkkvi2gXZ31CMABVSbqRjSKfO1rLQ5rJ/0V+80Knd vc2VYjDeaiJkRhwBLjxDM0NDJ7YO14ujZq1hfZecOQ6mG99LXSazgx2gud3RzaKgnKlj Ply7KDgPck3X3rq078NZyLhm+SuzgN7wY5wrJ3+UDsLlh8v7zrhRHjcTgY/2zLIhHZDF gBhS0XAdxIOTok4v+Nsr+sR9hMsyR5nhVyEC6Kuk8AVU6FHB3KeE47IDnUHBcsPJuOv8 yFEcUlArPRQaPDuxXAJnPARoHgzhZk8mLRpoh0hfTcAv1sp/jMk9DTmVX1w7+N61Ci88 9GVQ==
X-Gm-Message-State	ALoCoQlpfW/8eKVyk2wfzNv3UCbC8iYDCG3TL4Usg7AIohXbT5+5Lk4FOwxFxKFj2GrklEkmnLe+9OAWvJEbuNviBfKZcdxEqQnZ7Z1iowNMvCgAvF8H5FM=
MIME-Version	1.0
X-Received	by 10.182.247.105 with SMTP id yd9mr10498605obc.21.1449768875316; Thu, 10 Dec 2015 09:34:35 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	43
Organization	linux.* mail to news gateway
X-Original-Cc	Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Alexandre Courbot <gnurou@gmail.com>, Samuel Ortiz <sameo@linux.intel.com>, Lee Jones <lee.jones@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
X-Original-Date	Thu, 10 Dec 2015 18:34:35 +0100
X-Original-Message-ID	<CACRpkdZxZy=ZgeW-DwpNwC4KF+RvzQjYB=acVe47Wj7ALQ8Rig@mail.gmail.com>
X-Original-References	<1447869580-10416-1-git-send-email-afd@ti.com> <1447869580-10416-6-git-send-email-afd@ti.com> <CACRpkdbV+FzEXC_6HqRMRONY5fHoUWzg0HdoXq_s2N-RYphpVA@mail.gmail.com> <565DF7BD.6010204@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1288733

Show key headers only | View raw

On Tue, Dec 1, 2015 at 8:40 PM, Andrew F. Davis <afd@ti.com> wrote:
> On 11/30/2015 02:26 AM, Linus Walleij wrote:
>>
>> On Wed, Nov 18, 2015 at 6:59 PM, Andrew F. Davis <afd@ti.com> wrote:
>>
>>> This patch adds support for the TPS65912 PMIC GPIOs.
>>>
>>> TPS65912 has five configurable GPIOs that can be used for several
>>> purposes.
>>>
>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>
>>
>> (...)
>>>
>>> +       gpio->tps = dev_get_drvdata(pdev->dev.parent);
>>> +       gpio->gpio_chip = template_chip;
>>> +       gpio->gpio_chip.dev = tps->dev;
>>
>>
>> This is now renamed .parent in linux-next. It needs to be changed if the
>> code should compile after merge.
>>
>
> Are you able to make this change when you pick this up or would you
> like me to resend this?

I guess all these need to be applied together?

It's probably best if Lee apply all and provide them on an immutable
branch, and I
will apply fixes on top after pulling that in.

I recently did exactly that with an AC97 driver from ALSA SoC.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912  PMIC "Andrew F. Davis" <afd@ti.com> - 2015-12-01 20:50 +0100
  Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC Linus Walleij <linus.walleij@linaro.org> - 2015-12-10 18:40 +0100

csiph-web