Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1288733

Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC

From Linus Walleij <linus.walleij@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC
Date 2015-12-10 18:40 +0100
Message-ID <qEdmc-OR-71@gated-at.bofh.it> (permalink)
References <qwfl8-6tM-5@gated-at.bofh.it> <qwfl8-6tM-21@gated-at.bofh.it> <qAs0q-17U-25@gated-at.bofh.it> <qAZ61-5u6-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Dec 1, 2015 at 8:40 PM, Andrew F. Davis <afd@ti.com> wrote:
> On 11/30/2015 02:26 AM, Linus Walleij wrote:
>>
>> On Wed, Nov 18, 2015 at 6:59 PM, Andrew F. Davis <afd@ti.com> wrote:
>>
>>> This patch adds support for the TPS65912 PMIC GPIOs.
>>>
>>> TPS65912 has five configurable GPIOs that can be used for several
>>> purposes.
>>>
>>> Signed-off-by: Andrew F. Davis <afd@ti.com>
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>
>>
>> (...)
>>>
>>> +       gpio->tps = dev_get_drvdata(pdev->dev.parent);
>>> +       gpio->gpio_chip = template_chip;
>>> +       gpio->gpio_chip.dev = tps->dev;
>>
>>
>> This is now renamed .parent in linux-next. It needs to be changed if the
>> code should compile after merge.
>>
>
> Are you able to make this change when you pick this up or would you
> like me to resend this?

I guess all these need to be applied together?

It's probably best if Lee apply all and provide them on an immutable
branch, and I
will apply fixes on top after pulling that in.

I recently did exactly that with an AC97 driver from ALSA SoC.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912  PMIC "Andrew F. Davis" <afd@ti.com> - 2015-12-01 20:50 +0100
  Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC Linus Walleij <linus.walleij@linaro.org> - 2015-12-10 18:40 +0100

csiph-web