Re: [PATCH] Fixed coding style problems based on checkpatch.pl for goldfish_audio.c

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Benjamin Young <youngcdev@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Fixed coding style problems based on checkpatch.pl for goldfish_audio.c
Date	Thu, 10 Dec 2015 18:40:03 +0100
Message-ID	<qEdmb-OR-47@gated-at.bofh.it> (permalink)
References	<qDWEF-6Dw-1@gated-at.bofh.it> <qE3Ga-2Ub-15@gated-at.bofh.it>
X-Original-To	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=J69lJcRBIP4Iw/fuWc8jsSk7xTYimXAMWRbjOBUB9V4=; b=fbE0MPz5M6vALvj/vsKfBOKP55iHjAW7VdC5n228iRT3uxt+MkdeHpajhJjqeXwV1x iZb9yDDB1ygA5g605qWkpH4+/dnQ2jyuFruf/29+oY07J4LtnPFPj7/4IEb8KVwQD/ER 5N1lpbxdrrNN5XuQGLW8eh1pCn0bBIRParlgf8VhjCaH3DAREOcVi0Tbwv06Q8J1eJHW B3egAELJ4wdqZtCthHzlNADhEI4Vhxbso5Z7aPOVjILGPfzqSF8CCmotdh/Ji+iB9bVb w6Zf/SEtBak6cNMNy3nDGuf+5L0SlO0uxdFoURpnbr1y6TLQQgSi2r+3fklmP9yxeRMP sYpw==
X-Received	by 10.182.120.4 with SMTP id ky4mr10548308obb.16.1449768927172; Thu, 10 Dec 2015 09:35:27 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	28
Organization	linux.* mail to news gateway
X-Original-Cc	gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 10 Dec 2015 09:35:24 -0800
X-Original-Message-ID	<20151210173523.GA2530@gmail.com>
X-Original-References	<20151209234602.GA3817@gmail.com> <20151210071319.GA5814@sudip-pc>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1288726

Show key headers only | View raw

On Thu, Dec 10, 2015 at 12:43:19PM +0530, Sudip Mukherjee wrote:
> On Wed, Dec 09, 2015 at 03:46:02PM -0800, Benjamin Young wrote:
> > From f18a3e5f155f5258d2d19ac6b56bfaafa2ad470b Mon Sep 17 00:00:00 2001
> > From: Benjamin Young <youngcdev@gmail.com>
> > Date: Wed, 9 Dec 2015 13:45:00 -0800
> > Subject: [PATCH] Fixed coding style problems based on checkpatch.pl for
> >  goldfish_audio.c
> 
> This should not be here.
> You have not given in commit message and you are doing multiple changes
> in this patch. Please split them into separate patch, each patch doing
> only a single type of change.
> 
> regards
> sudip

Thanks Sudip I will fix this by creating two new patches.
One for the comparison to null checks and the other for space between operators.

Was there anything else which I could improve on for this commit?

Thanks,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Fixed coding style problems based on checkpatch.pl for  goldfish_audio.c Benjamin Young <youngcdev@gmail.com> - 2015-12-10 00:50 +0100
  Re: [PATCH] Fixed coding style problems based on checkpatch.pl for  goldfish_audio.c Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-10 08:20 +0100
    Re: [PATCH] Fixed coding style problems based on checkpatch.pl for  goldfish_audio.c Benjamin Young <youngcdev@gmail.com> - 2015-12-10 18:40 +0100

csiph-web