Re: [PATCH] Fixed coding style problems based on checkpatch.pl for goldfish_audio.c

From	Benjamin Young <youngcdev@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Fixed coding style problems based on checkpatch.pl for goldfish_audio.c
Date	2015-12-10 18:40 +0100
Message-ID	<qEdmb-OR-47@gated-at.bofh.it> (permalink)
References	<qDWEF-6Dw-1@gated-at.bofh.it> <qE3Ga-2Ub-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Dec 10, 2015 at 12:43:19PM +0530, Sudip Mukherjee wrote:
> On Wed, Dec 09, 2015 at 03:46:02PM -0800, Benjamin Young wrote:
> > From f18a3e5f155f5258d2d19ac6b56bfaafa2ad470b Mon Sep 17 00:00:00 2001
> > From: Benjamin Young <youngcdev@gmail.com>
> > Date: Wed, 9 Dec 2015 13:45:00 -0800
> > Subject: [PATCH] Fixed coding style problems based on checkpatch.pl for
> >  goldfish_audio.c
> 
> This should not be here.
> You have not given in commit message and you are doing multiple changes
> in this patch. Please split them into separate patch, each patch doing
> only a single type of change.
> 
> regards
> sudip

Thanks Sudip I will fix this by creating two new patches.
One for the comparison to null checks and the other for space between operators.

Was there anything else which I could improve on for this commit?

Thanks,
Benjamin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Fixed coding style problems based on checkpatch.pl for  goldfish_audio.c Benjamin Young <youngcdev@gmail.com> - 2015-12-10 00:50 +0100
  Re: [PATCH] Fixed coding style problems based on checkpatch.pl for  goldfish_audio.c Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-12-10 08:20 +0100
    Re: [PATCH] Fixed coding style problems based on checkpatch.pl for  goldfish_audio.c Benjamin Young <youngcdev@gmail.com> - 2015-12-10 18:40 +0100

csiph-web