Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1288783

[PATCH v3 4/9] usb: host: ehci.h: fix single statement macros

Show all headers | View raw

Don't use the 'do {} while (0)' wrapper in a single statement macro.

Caught by checkpatch: "WARNING: Single statement macros should not
use a do {} while (0) loop"

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
---
Change in v3:
 - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS
   false branch. Thus an empty #define is the choice.
---
 drivers/usb/host/ehci.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
index cfeebd8..c86194f 100644
--- a/drivers/usb/host/ehci.h
+++ b/drivers/usb/host/ehci.h
@@ -244,9 +244,9 @@ struct ehci_hcd {			/* one per controller */
 	/* irq statistics */
 #ifdef EHCI_STATS
 	struct ehci_stats	stats;
-#	define COUNT(x) do { (x)++; } while (0)
+#	define COUNT(x) ((x)++)
 #else
-#	define COUNT(x) do {} while (0)
+#	define COUNT(x)
 #endif
 
 	/* debug files */
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/9] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 19:20 +0100
  Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-11 21:30 +0100
    Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 22:00 +0100
      Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 22:30 +0100

csiph-web