Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1289895

Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros

Show all headers | View raw

2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>:
> On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote:
>> Don't use the 'do {} while (0)' wrapper in a single statement macro.
>>
>> Caught by checkpatch: "WARNING: Single statement macros should not
>> use a do {} while (0) loop"
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> Change in v3:
>>  - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS
>>    false branch. Thus an empty #define is the choice.
>
> Odd numbering scheme of patches, I can't figure this out...
Greg,

I sent new versions only to modified ones.
9 is v1.
4 is v3.
rest is v2.

Next time I'll send new versions for all.

>
> Can you resend this whole series so I know I got it all correct?
I hope so. :-) Messing around with branches and merges here. I tell you soon.

>
> thanks,
>
> greg k-h



-- 
Regards,

Geyslan G. Bem
hackingbits.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 4/9] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 19:20 +0100
  Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-11 21:30 +0100
    Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 22:00 +0100
      Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-11 22:30 +0100

csiph-web