Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom NSP SoC
Date	Thu, 10 Dec 2015 18:00:02 +0100
Message-ID	<qEcJs-k8-7@gated-at.bofh.it> (permalink)
References	<qwY8y-1Yw-21@gated-at.bofh.it> <qAw42-3HZ-3@gated-at.bofh.it> <qAA7D-6si-15@gated-at.bofh.it>
X-Original-To	Ray Jui <rjui@broadcom.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=4OFuN8rOodcbBF5CKxZILjyWUCxoY0zAR21v2qELoek=; b=x/OB4GafSzTHOpuQ5EeIrj4zN09COGqvUKPk8neTuA0lkn4vzeO70RbGoSnNjdgB2N JpgAQ4FpmO0UR5n4awCnt0UluTrTXtAp77glfb0Xv2SNPEjMFvpNGAyW9e3Lzi/t1hCW rumHDxbi6N8c5UqjOu2ladOJ3/K7y7uOT5+LIhiuAdfA7yQnJp3ckIVenpYgPZ6MVD9Z RL8ax8trOx3p9BEns2kZO6d6ZOS2t/sB4nCpD27cjvzWwjYRhBk04gSTCJol9xogJkHa jtemGBk5XScN2OTwwxuBS2mVSzRD3hhDDhnZCRcmHhgpcsxHa0MhWqs3v+9Z9QMtCnoY +INg==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=4OFuN8rOodcbBF5CKxZILjyWUCxoY0zAR21v2qELoek=; b=UpyT9WQ9W4yKqIN9HzsPdeqEJcS8nYb4ruDPcjTRRTBWFU1/0ZAUA1xL8ZwTyWnlwy ntO32nBGjuw8cNDiHd0p1hqNxSdRqNd8vi4kKt4j8H53FLvBtE9lFKvQ9/XTXWf9U+ee 4FXBCWCDDvKJY4caSgAmwvP8w2jmgJ6osss647O+3AILa5OdLO03wzkpJnujLj+FNuUh pNN5LvQDBrWnCKJFJ8r9MsewkiP6Cj6PJRthx5wwCKAblT9j4ZG0OQaAcG+nlsEuZb87 yTPUkLbwRr6G5wT4EE/8ygfkcecmw3a8r8T27v00173H6yoQ8cQlD+YnwCzr0RGWCiCr Ixsg==
X-Gm-Message-State	ALoCoQnQyLERc/g9n4NjjMBCUAi1kQ2aOx24Ljct4MM3ZR0PD8gz2SXoNJquk6+YGWvC6c0t7jvcZYMNSs5NDjPrVm4u0xFpn8mWhkPnZSEy9mwUCVf7kNk=
MIME-Version	1.0
X-Received	by 10.60.98.33 with SMTP id ef1mr6841271oeb.62.1449766224517; Thu, 10 Dec 2015 08:50:24 -0800 (PST)
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>, Stephen Warren <swarren@wwwdotorg.org>, Scott Branden <sbranden@broadcom.com>, Jon Mason <jonmason@broadcom.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>
X-Original-Date	Thu, 10 Dec 2015 17:50:24 +0100
X-Original-Message-ID	<CACRpkdaytru_AOK4p9Si9fJs6=DKgrqJ6HV4-To_a8Q+R+40jA@mail.gmail.com>
X-Original-References	<1448042245-25702-1-git-send-email-yrdreddy@broadcom.com> <CACRpkdZ=vyPSiPCUppfDWC9OShqfe-BRvB5QjU1AZmbDbYvsZQ@mail.gmail.com> <565C81E4.90507@broadcom.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1288671

Show key headers only | View raw

On Mon, Nov 30, 2015 at 6:05 PM, Ray Jui <rjui@broadcom.com> wrote:
> Hi Linus,
>
> On 11/30/2015 4:49 AM, Linus Walleij wrote:
>>
>> On Fri, Nov 20, 2015 at 6:57 PM, Yendapally Reddy Dhananjaya Reddy
>> <yrdreddy@broadcom.com> wrote:
>>
>>> This adds the initial support of the Broadcom NSP pinmux driver.
>>>
>>> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yrdreddy@broadcom.com>
>>
>>
>> So what does Ray and Stephen say about this?
>>
>> Is the hardware unique enough to warrant its own driver?
>>
>> Or should it utilize/extend one of the existing Broadcom
>> drivers?
>
>
> Currently, the IOMUX configurations in Cygnus, NSP, and NS2 are completely
> different and require a separate driver to each of these SoCs. We now
> realize the shortcomings and have been communicating with our ASIC team.
> We'd like to fix this for the next-gen of our SoC. We are driving towards
> using a register layout that will allow us to use just "pinctrl-single" and
> "pinconf-single."

OK can you provide your reviews for the NSP driver?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom  NSP SoC Ray Jui <rjui@broadcom.com> - 2015-11-30 18:10 +0100
  Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom  NSP SoC Linus Walleij <linus.walleij@linaro.org> - 2015-12-10 18:00 +0100
    Re: [PATCH 2/3] pinctrl: nsp: add pinmux driver support for Broadcom  NSP SoC Ray Jui <rjui@broadcom.com> - 2015-12-11 00:00 +0100

csiph-web