Re: [PATCH] usb: remove redundant conditions

From	Felipe Balbi <balbi@ti.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] usb: remove redundant conditions
Date	2015-12-10 16:20 +0100
Message-ID	<qEbaF-7V7-5@gated-at.bofh.it> (permalink)
References	<qDYGu-7Sr-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

"Geyslan G. Bem" <geyslan@gmail.com> writes:

> This patch removes redundant conditions.
>
>  - (!A || (A && B)) is the same as (!A || B).
>  - (length && length > 5) can be reduced to a single evaluation.
>
> Caught by: cppcheck
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> ---

I guess you didn't get previous comment in time; let's split this per
driver so different maintainers can pick their parts.

-- 
balbi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 03:00 +0100
  Re: [PATCH] usb: remove redundant conditions Johan Hovold <johan@kernel.org> - 2015-12-10 11:50 +0100
    Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 12:00 +0100
  Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:00 +0100
  Re: [PATCH] usb: remove redundant conditions Felipe Balbi <balbi@ti.com> - 2015-12-10 16:00 +0100
  Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:20 +0100
    Re: [PATCH] usb: remove redundant conditions Felipe Balbi <balbi@ti.com> - 2015-12-10 16:40 +0100
  RE: [PATCH] usb: remove redundant conditions David Laight <David.Laight@ACULAB.COM> - 2015-12-10 16:20 +0100
    Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:40 +0100
    Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:40 +0100
  Re: [PATCH] usb: remove redundant conditions Felipe Balbi <balbi@ti.com> - 2015-12-10 16:20 +0100

csiph-web