Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1288442
| From | "Geyslan G. Bem" <geyslan@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usb: remove redundant conditions |
| Date | 2015-12-10 12:00 +0100 |
| Message-ID | <qE774-569-7@gated-at.bofh.it> (permalink) |
| References | <qDYGu-7Sr-13@gated-at.bofh.it> <qE6Xn-52l-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2015-12-10 7:44 GMT-03:00 Johan Hovold <johan@kernel.org>: > On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote: >> This patch removes redundant conditions. >> >> - (!A || (A && B)) is the same as (!A || B). >> - (length && length > 5) can be reduced to a single evaluation. >> >> Caught by: cppcheck >> >> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> >> --- >> drivers/usb/gadget/udc/s3c-hsudc.c | 2 +- >> drivers/usb/host/fhci-sched.c | 2 +- >> drivers/usb/musb/musb_gadget.c | 5 ++--- >> drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++--------------------- >> drivers/usb/serial/mos7840.c | 2 +- >> 5 files changed, 19 insertions(+), 27 deletions(-) > > Please split out (at least) the usb-serial changes into two patches. Ok, I'll send v2 later. > > Johan -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 03:00 +0100
Re: [PATCH] usb: remove redundant conditions Johan Hovold <johan@kernel.org> - 2015-12-10 11:50 +0100
Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 12:00 +0100
Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:00 +0100
Re: [PATCH] usb: remove redundant conditions Felipe Balbi <balbi@ti.com> - 2015-12-10 16:00 +0100
Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:20 +0100
Re: [PATCH] usb: remove redundant conditions Felipe Balbi <balbi@ti.com> - 2015-12-10 16:40 +0100
RE: [PATCH] usb: remove redundant conditions David Laight <David.Laight@ACULAB.COM> - 2015-12-10 16:20 +0100
Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:40 +0100
Re: [PATCH] usb: remove redundant conditions "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-10 16:40 +0100
Re: [PATCH] usb: remove redundant conditions Felipe Balbi <balbi@ti.com> - 2015-12-10 16:20 +0100
csiph-web