Re: [PATCH] drivers:pci:host Fix missing line after declarations

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	sasa bogicevic <brutallesale@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers:pci:host Fix missing line after declarations
Date	Sat, 12 Dec 2015 14:10:01 +0100
Message-ID	<qES5X-2zo-3@gated-at.bofh.it> (permalink)
References	<qEQQy-1Ce-5@gated-at.bofh.it> <qERtg-251-3@gated-at.bofh.it>
X-Original-To	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=In2/9Q8xnFZA9DvvXE33ISo1+yfAE/Uld9VYzRgu3HM=; b=byx8bf79tysuHCGx8HSy7PiIISCnUUWNnbLkyodzaQp9/FyZKYXoJvwa9tScpdgJww M9GjyD8LfEGaAKQEpWx/8S+kqMZhavXfdBLVSNfJ6FBhcHcw7ARqYPlXuqzru2gQIRVK zRA/z/hsykcgOXGei0E5iKZGhAm2wb3gSfk4Y40JWtYOOb/uo6pP60Bp4O2Z/+W14qP8 TkqYheur52hivf1FeCboQYJvtO32Pz0MamF59ePjsKf7+TCHWLooymn5QLideAuTftWs VSP2GuqQ1JjcXeaZDMwv+sybsqZ3Az8B/WIkl8WEdouds22kiRjMs2oghU1/xty4EoCe O+SA==
X-Received	by 10.194.117.163 with SMTP id kf3mr26106419wjb.139.1449925383089; Sat, 12 Dec 2015 05:03:03 -0800 (PST)
Content-Type	text/plain; charset=utf-8
MIME-Version	1.0 (Mac OS X Mail 9.2 \(3112\))
Content-Transfer-Encoding	8BIT
X-Mailer	Apple Mail (2.3112)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	bhelgaas@google.com, Richard.Zhu@freescale.com, l.stach@penguintronix.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 12 Dec 2015 14:03:01 +0100
X-Original-Message-ID	<FA0282DC-E821-413F-AC5A-11105B4D0EDE@gmail.com>
X-Original-References	<1449920508-105873-1-git-send-email-brutallesale@gmail.com> <20151212132316.27e10a6d@free-electrons.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1290183

Show key headers only | View raw

Hi Thomas,
I just went with checkpatch.pl approach I hope this patch didn’t ruin your day :)


{
	name: Bogicevic Sasa
	phone: +381606006200
}



> On Dec 12, 2015, at 13:23, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> 
> Dear Bogicevic Sasa,
> 
> On Sat, 12 Dec 2015 03:41:48 -0800, Bogicevic Sasa wrote:
>> This fixes few warnings about missing line after declarations and one
>> no whitespace is necesarry before that "("
>> 
>> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>
> 
> I am not a big fan of this struct rule that insists in having an empty
> line after declarations, I believe when a for() loop or if() condition
> has only one line of declaration and one line of useful code, it
> doesn't make much sense. But oh well, that's the rule, so let's do it
> this way.
> 
>> ---
>> drivers/pci/host/pci-imx6.c  | 2 +-
>> drivers/pci/host/pci-mvebu.c | 3 +++
>> drivers/pci/host/pcie-rcar.c | 2 ++
>> 3 files changed, 6 insertions(+), 1 deletion(-)
> 
> For the pci-mvebu.c part:
> 
> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drivers:pci:host Fix missing line after declarations Bogicevic Sasa <brutallesale@gmail.com> - 2015-12-12 12:50 +0100
  Re: [PATCH] drivers:pci:host Fix missing line after declarations Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-12-12 13:30 +0100
    Re: [PATCH] drivers:pci:host Fix missing line after declarations sasa bogicevic <brutallesale@gmail.com> - 2015-12-12 14:10 +0100

csiph-web