Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290178

Re: [PATCH] drivers:pci:host Fix missing line after declarations

Show all headers | View raw

Dear Bogicevic Sasa,

On Sat, 12 Dec 2015 03:41:48 -0800, Bogicevic Sasa wrote:
> This fixes few warnings about missing line after declarations and one
> no whitespace is necesarry before that "("
> 
> Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com>

I am not a big fan of this struct rule that insists in having an empty
line after declarations, I believe when a for() loop or if() condition
has only one line of declaration and one line of useful code, it
doesn't make much sense. But oh well, that's the rule, so let's do it
this way.

> ---
>  drivers/pci/host/pci-imx6.c  | 2 +-
>  drivers/pci/host/pci-mvebu.c | 3 +++
>  drivers/pci/host/pcie-rcar.c | 2 ++
>  3 files changed, 6 insertions(+), 1 deletion(-)

For the pci-mvebu.c part:

Reviewed-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drivers:pci:host Fix missing line after declarations Bogicevic Sasa <brutallesale@gmail.com> - 2015-12-12 12:50 +0100
  Re: [PATCH] drivers:pci:host Fix missing line after declarations Thomas Petazzoni <thomas.petazzoni@free-electrons.com> - 2015-12-12 13:30 +0100
    Re: [PATCH] drivers:pci:host Fix missing line after declarations sasa bogicevic <brutallesale@gmail.com> - 2015-12-12 14:10 +0100

csiph-web