Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290061

[PATCH] usb: host: ehci-sched: silence checkpatch warning

Show all headers | View raw

This patch moves comment into the else branch avoiding the following
misleading warning.

"braces {} are not necessary for single statement blocks"

Caught by checkpatch.

Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
Suggested-by: Joe Perches <joe@perches.com>
---
 drivers/usb/host/ehci-sched.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
index f6e828a..b2af0b3 100644
--- a/drivers/usb/host/ehci-sched.c
+++ b/drivers/usb/host/ehci-sched.c
@@ -1560,13 +1560,10 @@ iso_stream_schedule(
 					(stream->ps.bw_period - 1);
 			stream->ps.phase_uf = start & 7;
 			reserve_release_iso_bandwidth(ehci, stream, 1);
-		}
-
-		/* New stream is already scheduled; use the upcoming slot */
-		else {
+		} else {
+			/* New stream is already scheduled; use the upcoming slot */
 			start = (stream->ps.phase << 3) + stream->ps.phase_uf;
 		}
-
 		stream->next_uframe = start;
 		new_stream = true;
 	}
-- 
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] usb: host: ehci-sched: silence checkpatch warning "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-12 03:00 +0100
  Re: [PATCH] usb: host: ehci-sched: silence checkpatch warning "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-12 03:10 +0100
  Re: [PATCH] usb: host: ehci-sched: silence checkpatch warning Alan Stern <stern@rowland.harvard.edu> - 2015-12-12 17:20 +0100
    Re: [PATCH] usb: host: ehci-sched: silence checkpatch warning "Geyslan G. Bem" <geyslan@gmail.com> - 2015-12-12 17:40 +0100

csiph-web