Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1290060

Re: [PATCH] cpufreq: tegra: add regulator dependency for T124

Show all headers | View raw

On Tuesday, December 08, 2015 10:52:45 PM Arnd Bergmann wrote:
> This driver is the only one that calls regulator_sync_voltage(), but it
> can currently be built with CONFIG_REGULATOR disabled, producing
> this build error:
> 
> drivers/cpufreq/tegra124-cpufreq.c: In function 'tegra124_cpu_switch_to_pllx':
> drivers/cpufreq/tegra124-cpufreq.c:68:2: error: implicit declaration of function 'regulator_sync_voltage' [-Werror=implicit-function-declaration]
>   regulator_sync_voltage(priv->vdd_cpu_reg);
> 
> My first attempt was to implement a helper for this function
> for regulator_sync_voltage, but Mark Brown explained:
> 
>    We don't do this for *all* regulator API functions - there's some where
>    using them strongly suggests that there is actually a dependency on
>    the regulator API.  This does seem like it might be falling into the
>    specialist category [...]
>    Looking at the code I'm pretty unclear on what the authors think the
>    use of _sync_voltage() is doing in the first place so it may be even
>    better to just remove the call.  It seems to have been included in the
>    first commit so there's not changelog explaining things and there's
>    no comment either.  I'd *expect* it to be a noop as far as I can see.
> 
> This adds the dependency to make the driver always build successfully
> or not be enabled at all. Alternatively, we could investigate if the
> driver should stop calling regulator_sync_voltage instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks!

Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: tegra: add regulator dependency for T124 Arnd Bergmann <arnd@arndb.de> - 2015-12-08 23:00 +0100
  Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Viresh Kumar <viresh.kumar@linaro.org> - 2015-12-09 03:20 +0100
  Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Jon Hunter <jonathanh@nvidia.com> - 2015-12-09 13:10 +0100
    Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Mark Brown <broonie@kernel.org> - 2015-12-09 15:50 +0100
      Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Jon Hunter <jonathanh@nvidia.com> - 2015-12-09 18:40 +0100
        Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Mark Brown <broonie@kernel.org> - 2015-12-09 21:20 +0100
          Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Jon Hunter <jonathanh@nvidia.com> - 2015-12-10 11:10 +0100
            Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Mark Brown <broonie@kernel.org> - 2015-12-10 12:40 +0100
              Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 Jon Hunter <jonathanh@nvidia.com> - 2015-12-10 13:20 +0100
  Re: [PATCH] cpufreq: tegra: add regulator dependency for T124 "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-12 03:00 +0100

csiph-web