Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1286686

Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

Path csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!news.roellig-ltd.de!open-news-network.org!weretis.net!feeder1.news.weretis.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] regulator: add regulator_sync_voltage inline dummy
Date Tue, 08 Dec 2015 18:00:02 +0100
Message-ID <qDtMm-4Ra-3@gated-at.bofh.it> (permalink)
References <qDsGC-4bA-15@gated-at.bofh.it> <qDtt0-4J4-17@gated-at.bofh.it> <qDtMm-4Ra-5@gated-at.bofh.it>
X-Original-To Arnd Bergmann <arnd@arndb.de>
MIME-Version 1.0
Content-Type multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KqBSqvdnnccM6+Kg"
Content-Disposition inline
X-Cookie revolutionary, adj.:
User-Agent Mutt/1.5.24 (2015-08-30)
X-Sa-Exim-Connect-IP 94.175.94.161
X-Sa-Exim-Mail-From broonie@sirena.org.uk
X-Sa-Exim-Version 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned Yes (on mezzanine.sirena.org.uk)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 46
Organization linux.* mail to news gateway
X-Original-Cc Liam Girdwood <lgirdwood@gmail.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tuomas Tynkkynen <ttynkkynen@nvidia.com>, Thierry Reding <treding@nvidia.com>
X-Original-Date Tue, 8 Dec 2015 16:54:56 +0000
X-Original-Message-ID <20151208165456.GT5727@sirena.org.uk>
X-Original-References <1983152.2iYiBkp4xd@wuerfel> <20151208163739.GS5727@sirena.org.uk> <18141514.YrJxqxh5jL@wuerfel>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1286686

Show key headers only | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Dec 08, 2015 at 05:49:20PM +0100, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 16:37:39 Mark Brown wrote:
> > On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote:

> > We don't do this for *all* regulator API functions - there's some where
> > using them strongly suggests that there is actually a dependency on the
> > regulator API.  This does seem like it might be falling into the
> > specialist category...

> Ok, got it.

> I guess we'll want something like the patch below in the cpufreq git, right?

Yes, exactly - though looking at the code I'm pretty unclear on what the
authors think the use of _sync_voltage() is doing in the first place so
it may be even better to just remove the call.  It seems to have been
included in the first commit so there's not changelog explaining things
and there's no comment either.  I'd *expect* it to be a noop as far as I
can see.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] regulator: add regulator_sync_voltage inline dummy Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:50 +0100
  Re: [PATCH] regulator: add regulator_sync_voltage inline dummy Mark Brown <broonie@kernel.org> - 2015-12-08 17:40 +0100
    Re: [PATCH] regulator: add regulator_sync_voltage inline dummy Mark Brown <broonie@kernel.org> - 2015-12-08 18:00 +0100
    Re: [PATCH] regulator: add regulator_sync_voltage inline dummy Arnd Bergmann <arnd@arndb.de> - 2015-12-08 18:00 +0100

csiph-web