Re: [PATCH] regulator: add regulator_sync_voltage inline dummy

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] regulator: add regulator_sync_voltage inline dummy
Date	2015-12-08 18:00 +0100
Message-ID	<qDtMm-4Ra-3@gated-at.bofh.it> (permalink)
References	<qDsGC-4bA-15@gated-at.bofh.it> <qDtt0-4J4-17@gated-at.bofh.it> <qDtMm-4Ra-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Dec 08, 2015 at 05:49:20PM +0100, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 16:37:39 Mark Brown wrote:
> > On Tue, Dec 08, 2015 at 04:43:35PM +0100, Arnd Bergmann wrote:

> > We don't do this for *all* regulator API functions - there's some where
> > using them strongly suggests that there is actually a dependency on the
> > regulator API.  This does seem like it might be falling into the
> > specialist category...

> Ok, got it.

> I guess we'll want something like the patch below in the cpufreq git, right?

Yes, exactly - though looking at the code I'm pretty unclear on what the
authors think the use of _sync_voltage() is doing in the first place so
it may be even better to just remove the call.  It seems to have been
included in the first commit so there's not changelog explaining things
and there's no comment either.  I'd *expect* it to be a noop as far as I
can see.

Thread

[PATCH] regulator: add regulator_sync_voltage inline dummy Arnd Bergmann <arnd@arndb.de> - 2015-12-08 16:50 +0100
  Re: [PATCH] regulator: add regulator_sync_voltage inline dummy Mark Brown <broonie@kernel.org> - 2015-12-08 17:40 +0100
    Re: [PATCH] regulator: add regulator_sync_voltage inline dummy Mark Brown <broonie@kernel.org> - 2015-12-08 18:00 +0100
    Re: [PATCH] regulator: add regulator_sync_voltage inline dummy Arnd Bergmann <arnd@arndb.de> - 2015-12-08 18:00 +0100

csiph-web