Re: [PATCH] net: emac: emac gigabit ethernet controller driver

From	Gilad Avidov <gavidov@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: emac: emac gigabit ethernet controller driver
Date	2015-12-08 00:50 +0100
Message-ID	<qDdHz-2YK-11@gated-at.bofh.it> (permalink)
References	<qDcVc-2rG-7@gated-at.bofh.it> <qDdxU-2Vw-17@gated-at.bofh.it>
Organization	Qualcomm Innovation Center, Inc.

Show all headers | View raw

On Tue, 8 Dec 2015 00:33:04 +0100
Felix Fietkau <nbd@openwrt.org> wrote:


> On 2015-12-07 23:58, Gilad Avidov wrote:
> > +/* RRD (Receive Return Descriptor) */
> > +union emac_rrd {
> > +	struct {
> > +		/* 32bit word 0 */
> > +		u32  xsum:16;
> > +		u32  nor:4;       /* number of RFD */
> > +		u32  si:12;       /* start index of rfd-ring */
> > +		/* 32bit word 1 */
> > +		u32  hash;
> > +		/* 32bit word 2 */
> You should never use bitfields for hardware structs.
> I think in general, kernel code should be made endian safe, even if
> you only care about one particular endian type for your platform.
> 
> - Felix

Thank you Felix,
I will change the bit fields to bitwise operations and macros.

Gilad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] net: emac: emac gigabit ethernet controller driver Felix Fietkau <nbd@openwrt.org> - 2015-12-08 00:40 +0100
  Re: [PATCH] net: emac: emac gigabit ethernet controller driver Gilad Avidov <gavidov@codeaurora.org> - 2015-12-08 00:50 +0100

csiph-web