Re: [PATCH v5 08/10] spi: expose master transfer size limitation.

Path	csiph.com!news.mixmin.net!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 08/10] spi: expose master transfer size limitation.
Date	Mon, 07 Dec 2015 21:20:01 +0100
Message-ID	<qDaql-PS-7@gated-at.bofh.it> (permalink)
References	<qAZfI-5yU-17@gated-at.bofh.it> <qAZfI-5yU-19@gated-at.bofh.it> <qB2ng-7GU-19@gated-at.bofh.it> <qBZGG-3Ud-23@gated-at.bofh.it>
X-Original-To	Martin Sperl <martin@sperl.org>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QAdlk5ze2izLk3Ap"
Content-Disposition	inline
X-Cookie	revolutionary, adj.:
User-Agent	Mutt/1.5.24 (2015-08-30)
X-Sa-Exim-Connect-IP	94.175.94.161
X-Sa-Exim-Mail-From	broonie@sirena.org.uk
X-Sa-Exim-Version	4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000)
X-Sa-Exim-Scanned	Yes (on mezzanine.sirena.org.uk)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	Michal Suchanek <hramrach@gmail.com>, Heiner Kallweit <hkallweit1@gmail.com>, David Woodhouse <dwmw2@infradead.org>, Brian Norris <computersforpeace@gmail.com>, Han Xu <han.xu@freescale.com>, Boris Brezillon <boris.brezillon@free-electrons.com>, Javier Martinez Canillas <javier@osg.samsung.com>, Stephen Warren <swarren@nvidia.com>, "Andrew F. Davis" <afd@ti.com>, Marek Vasut <marex@denx.de>, Rafał Miłecki <zajec5@gmail.com>, Mika Westerberg <mika.westerberg@linux.intel.com>, Gabor Juhos <juhosg@openwrt.org>, Bean Huo 霍斌斌 <beanhuo@micron.com>, Furquan Shaikh <furquan@google.com>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
X-Original-Date	Mon, 7 Dec 2015 20:18:04 +0000
X-Original-Message-ID	<20151207201804.GP5727@sirena.org.uk>
X-Original-References	<cover.1448988089.git.hramrach@gmail.com> <8c34c7790244489c2ce0072c72bd9bc7c4cdb965.1448988089.git.hramrach@gmail.com> <20151201231233.GA1929@sirena.org.uk> <5FC39638-EEE0-4CFA-B464-0B4743CB6AB6@sperl.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1285894

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Fri, Dec 04, 2015 at 03:30:50PM +0100, Martin Sperl wrote:
> > On 02.12.2015, at 00:12, Mark Brown <broonie@kernel.org> wrote:

> > Can we change this to return SIZE_MAX instead (ie, the maximum value for
> > a size_t)?  That way callers don't need to worry if there is a limit, if
> > they want to handle it they can just unconditionally assume that a limit
> > will be provided.

> As I just came across: spi_master.max_dma_len, so I wonder how this 
> value would differ from the proposed spi_master.max_transfer_size
> on specific HW?

> For all practical purposes I would assume both are identical.

Yeah, we should probably just remove the DMA specific one in time though
it may be useful for some devices with built in DMA engines if they're
oddly limited I'm not sure how practical their DMA would be if it
differed from the overall transfer length.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Mark Brown <broonie@kernel.org> - 2015-12-02 00:20 +0100
  Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Michal Suchanek <hramrach@gmail.com> - 2015-12-02 10:40 +0100
  Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Martin Sperl <martin@sperl.org> - 2015-12-04 15:40 +0100
    Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Michal Suchanek <hramrach@gmail.com> - 2015-12-04 17:50 +0100
    Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Mark Brown <broonie@kernel.org> - 2015-12-07 21:20 +0100

csiph-web