Re: [PATCH v5 08/10] spi: expose master transfer size limitation.

From	Martin Sperl <martin@sperl.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 08/10] spi: expose master transfer size limitation.
Date	2015-12-04 15:40 +0100
Message-ID	<qBZGG-3Ud-23@gated-at.bofh.it> (permalink)
References	<qAZfI-5yU-17@gated-at.bofh.it> <qAZfI-5yU-19@gated-at.bofh.it> <qB2ng-7GU-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On 02.12.2015, at 00:12, Mark Brown <broonie@kernel.org> wrote:
> 
> On Tue, Dec 01, 2015 at 04:51:06PM -0000, Michal Suchanek wrote:
> 
>> +static inline size_t
>> +spi_max_transfer_size(struct spi_device *spi)
>> +{
>> +	struct spi_master *master = spi->master;
>> +	if (!master->max_transfer_size)
>> +		return 0;
>> +	return master->max_transfer_size(spi);
>> +}
> 
> Can we change this to return SIZE_MAX instead (ie, the maximum value for
> a size_t)?  That way callers don't need to worry if there is a limit, if
> they want to handle it they can just unconditionally assume that a limit
> will be provided.

As I just came across: spi_master.max_dma_len, so I wonder how this 
value would differ from the proposed spi_master.max_transfer_size
on specific HW?

For all practical purposes I would assume both are identical.

Martin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Mark Brown <broonie@kernel.org> - 2015-12-02 00:20 +0100
  Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Michal Suchanek <hramrach@gmail.com> - 2015-12-02 10:40 +0100
  Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Martin Sperl <martin@sperl.org> - 2015-12-04 15:40 +0100
    Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Michal Suchanek <hramrach@gmail.com> - 2015-12-04 17:50 +0100
    Re: [PATCH v5 08/10] spi: expose master transfer size limitation. Mark Brown <broonie@kernel.org> - 2015-12-07 21:20 +0100

csiph-web