Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1286963

Re: [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy

Show all headers | View raw

Hi Rob

On 12/08/2015 11:06 PM, Rob Herring wrote:
> On Mon, Dec 07, 2015 at 02:39:50PM +0800, Yakir Yang wrote:
>> Add dt binding documentation for rockchip display port PHY.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
> One possible typo below, otherwise:
>
> Acked-by: Rob Herring <robh@kernel.org>

Thanks, it's a typo :)

>> ---
>> Changes in v10: None
>> Changes in v9: None
>> Changes in v8:
>> - Remove the specific address in the example node name. (Heiko)
>>
>> Changes in v7:
>> - Simplify the commit message. (Kishon)
>>
>> Changes in v6: None
>> Changes in v5:
>> - Split binding doc's from driver changes. (Rob)
>> - Update the rockchip,grf explain in document, and correct the clock required
>>    elemets in document. (Rob & Heiko)
>>
>> Changes in v4: None
>> Changes in v3: None
>> Changes in v2: None
>>
>>   .../devicetree/bindings/phy/rockchip-dp-phy.txt    | 22 ++++++++++++++++++++++
>>   1 file changed, 22 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
>>
>> diff --git a/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt b/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
>> new file mode 100644
>> index 0000000..00902cb
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt
>> @@ -0,0 +1,22 @@
>> +Rockchip Soc Seroes Display Port PHY
>                     ^
> Is this supposed to be SerDes?

Hmmm... it shouldn't be SerDes, i guess i may want 'series' which copy 
from samsung-phy.txt.

Thanks for catch that, for now i think it should be "Rockchip specific 
extensions to the Analogix Display Port PHY". I would send the v10.1 to 
fix this typo :)

Thanks,
- Yakir

>
>> +------------------------------------
>> +
>> +Required properties:
>> +- compatible : should be one of the following supported values:
>> +	 - "rockchip.rk3288-dp-phy"
>> +- clocks: from common clock binding: handle to dp clock.
>> +	of memory mapped region.
>> +- clock-names: from common clock binding:
>> +	Required elements: "24m"
>> +- rockchip,grf: phandle to the syscon managing the "general register files"
>> +- #phy-cells : from the generic PHY bindings, must be 0;
>> +
>> +Example:
>> +
>> +edp_phy: edp-phy {
>> +	compatible = "rockchip,rk3288-dp-phy";
>> +	rockchip,grf = <&grf>;
>> +	clocks = <&cru SCLK_EDP_24M>;
>> +	clock-names = "24m";
>> +	#phy-cells = <0>;
>> +};
>> -- 
>> 1.9.1
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10 0/17] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:40 +0100
  [PATCH v10 06/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:40 +0100
  [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy Rob Herring <robh@kernel.org> - 2015-12-08 16:10 +0100
      Re: [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:20 +0100
  [PATCH v10 09/17] phy: Add driver for rockchip Display Port PHY Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 11/17] drm: rockchip: vop: add bpc and color mode setting Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 05/17] dt-bindings: add document for analogix display port driver Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 05/17] dt-bindings: add document for analogix display  port driver Rob Herring <robh@kernel.org> - 2015-12-08 16:10 +0100
      Re: [PATCH v10 05/17] dt-bindings: add document for analogix display  port driver Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:10 +0100
  [PATCH v10 13/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 16/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 17/17] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 08/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 08/17] dt-bindings: add document for rockchip variant  of analogix_dp Rob Herring <robh@kernel.org> - 2015-12-08 16:10 +0100
      Re: [PATCH v10 08/17] dt-bindings: add document for rockchip variant  of analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:10 +0100
  [PATCH v10 03/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 12/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 15/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 04/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 02/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after  plug in lookup failed Rob Herring <robh@kernel.org> - 2015-12-08 16:20 +0100
      Re: [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after  plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:30 +0100
  Re: [PATCH v10 01/17] drm: bridge: analogix/dp: split exynos dp  driver to bridge directory Yakir Yang <ykk@rock-chips.com> - 2015-12-07 08:40 +0100
  Re: [PATCH v10 0/17] Add Analogix Core Display Port Driver Heiko Stübner <heiko@sntech.de> - 2015-12-08 16:40 +0100
    Re: [PATCH v10 0/17] Add Analogix Core Display Port Driver Heiko Stübner <heiko@sntech.de> - 2015-12-09 16:00 +0100
  [PATCH v10.1 08/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:10 +0100
  [PATCH v10.1 05/17] dt-bindings: add document for analogix display port driver Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:10 +0100
  [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:20 +0100
    Re: [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd  after plug in lookup failed Rob Herring <robh@kernel.org> - 2015-12-09 05:30 +0100
      Re: [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd after  plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 07:00 +0100
  [PATCH v10.1 10/17] dt-bindings: add document for rockchip dp phy Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:20 +0100
  [PATCH v10.2 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 07:30 +0100
  [PATCH v10 19/19] drm: bridge: analogix/dp: Fix the possible dead lock in bridge disable time Yakir Yang <ykk@rock-chips.com> - 2015-12-10 10:00 +0100
  [PATCH v10 18/19] drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time Yakir Yang <ykk@rock-chips.com> - 2015-12-10 10:00 +0100
  [PATCH v10.1 15/19] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang <ykk@rock-chips.com> - 2015-12-10 10:00 +0100

csiph-web