Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1285037

[PATCH v10 15/17] drm: bridge: analogix/dp: move hpd detect to connector detect function

From Yakir Yang <ykk@rock-chips.com>
Newsgroups linux.kernel
Subject [PATCH v10 15/17] drm: bridge: analogix/dp: move hpd detect to connector detect function
Date 2015-12-07 07:50 +0100
Message-ID <qCXMu-Wu-25@gated-at.bofh.it> (permalink)
References <qCXCN-T6-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

This change just make a little clean to make code more like
drm core expect, move hdp detect code from bridge->enable(),
and place them into connector->detect().

Note: Gustavo Padovan try to remove the controller and phy
power on function in bind time at bellow commit:
	drm/exynos: do not start enabling DP at bind() phase

But for now the connector status don't hardcode to connected,
need to operate dp phy in .detect function, so we need to revert
parts if Gustavo Padovan's changes, add phy poweron
function in bind time.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Tested-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
Changes in v10:
- Revert parts of Gustavo Padovan's changes in commit:
	drm/exynos: do not start enabling DP at bind() phase
  Add dp phy poweron function in bind time.

Changes in v9: None
Changes in v8: None
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4:
- Take Jingoo suggest, add commit messages.

Changes in v3:
- move dp hpd detect to connector detect function.

Changes in v2: None

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 94968e4..0f42d73 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -901,12 +901,6 @@ static void analogix_dp_commit(struct analogix_dp_device *dp)
 			DRM_ERROR("failed to disable the panel\n");
 	}
 
-	ret = analogix_dp_detect_hpd(dp);
-	if (ret) {
-		/* Cable has been disconnected, we're done */
-		return;
-	}
-
 	ret = analogix_dp_handle_edid(dp);
 	if (ret) {
 		dev_err(dp->dev, "unable to handle edid\n");
@@ -941,6 +935,11 @@ static void analogix_dp_commit(struct analogix_dp_device *dp)
 
 enum drm_connector_status analogix_dp_detect(struct device *dev, bool force)
 {
+	struct analogix_dp_device *dp = dev_get_drvdata(dev);
+
+	if (analogix_dp_detect_hpd(dp))
+		return connector_status_disconnected;
+
 	return connector_status_connected;
 }
 EXPORT_SYMBOL_GPL(analogix_dp_detect);
@@ -1308,6 +1307,8 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev,
 
 	pm_runtime_enable(dev);
 
+	phy_power_on(dp->phy);
+
 	ret = devm_request_irq(&pdev->dev, dp->irq, analogix_dp_irq_handler,
 			       irq_flags, "analogix-dp", dp);
 	if (ret) {
-- 
1.9.1


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v10 0/17] Add Analogix Core Display Port Driver Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:40 +0100
  [PATCH v10 06/17] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:40 +0100
  [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy Rob Herring <robh@kernel.org> - 2015-12-08 16:10 +0100
      Re: [PATCH v10 10/17] dt-bindings: add document for rockchip dp phy Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:20 +0100
  [PATCH v10 09/17] phy: Add driver for rockchip Display Port PHY Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 11/17] drm: rockchip: vop: add bpc and color mode setting Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 05/17] dt-bindings: add document for analogix display port driver Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 05/17] dt-bindings: add document for analogix display  port driver Rob Herring <robh@kernel.org> - 2015-12-08 16:10 +0100
      Re: [PATCH v10 05/17] dt-bindings: add document for analogix display  port driver Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:10 +0100
  [PATCH v10 13/17] drm: bridge: analogix/dp: add max link rate and lane count limit for RK3288 Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 16/17] drm: bridge: analogix/dp: add edid modes parse in get_modes method Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 17/17] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 08/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 08/17] dt-bindings: add document for rockchip variant  of analogix_dp Rob Herring <robh@kernel.org> - 2015-12-08 16:10 +0100
      Re: [PATCH v10 08/17] dt-bindings: add document for rockchip variant  of analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:10 +0100
  [PATCH v10 03/17] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 12/17] drm: bridge: analogix/dp: add some rk3288 special registers setting Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 15/17] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 04/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 02/17] drm: bridge: analogix/dp: fix some obvious code style Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
  [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-07 07:50 +0100
    Re: [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after  plug in lookup failed Rob Herring <robh@kernel.org> - 2015-12-08 16:20 +0100
      Re: [PATCH v10 14/17] drm: bridge: analogix/dp: try force hpd after  plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 02:30 +0100
  Re: [PATCH v10 01/17] drm: bridge: analogix/dp: split exynos dp  driver to bridge directory Yakir Yang <ykk@rock-chips.com> - 2015-12-07 08:40 +0100
  Re: [PATCH v10 0/17] Add Analogix Core Display Port Driver Heiko Stübner <heiko@sntech.de> - 2015-12-08 16:40 +0100
    Re: [PATCH v10 0/17] Add Analogix Core Display Port Driver Heiko Stübner <heiko@sntech.de> - 2015-12-09 16:00 +0100
  [PATCH v10.1 08/17] dt-bindings: add document for rockchip variant of analogix_dp Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:10 +0100
  [PATCH v10.1 05/17] dt-bindings: add document for analogix display port driver Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:10 +0100
  [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:20 +0100
    Re: [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd  after plug in lookup failed Rob Herring <robh@kernel.org> - 2015-12-09 05:30 +0100
      Re: [PATCH v10.1 14/17] drm: bridge: analogix/dp: try force hpd after  plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 07:00 +0100
  [PATCH v10.1 10/17] dt-bindings: add document for rockchip dp phy Yakir Yang <ykk@rock-chips.com> - 2015-12-09 03:20 +0100
  [PATCH v10.2 14/17] drm: bridge: analogix/dp: try force hpd after plug in lookup failed Yakir Yang <ykk@rock-chips.com> - 2015-12-09 07:30 +0100
  [PATCH v10 19/19] drm: bridge: analogix/dp: Fix the possible dead lock in bridge disable time Yakir Yang <ykk@rock-chips.com> - 2015-12-10 10:00 +0100
  [PATCH v10 18/19] drm: bridge: analogix/dp: add panel prepare/unprepare in suspend/resume time Yakir Yang <ykk@rock-chips.com> - 2015-12-10 10:00 +0100
  [PATCH v10.1 15/19] drm: bridge: analogix/dp: move hpd detect to connector detect function Yakir Yang <ykk@rock-chips.com> - 2015-12-10 10:00 +0100

csiph-web