Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1285212
| From | Ohad Ben-Cohen <ohad@wizery.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 04/10] omap_hwspinlock: Replace "hweight_long(i & 0xf) != 1" with "!is_power_of_2(i & 0xf)" |
| Date | 2015-12-07 12:10 +0100 |
| Message-ID | <qD1Q5-3GX-7@gated-at.bofh.it> (permalink) |
| References | <qCETv-5Ko-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi, On Sun, Dec 6, 2015 at 12:33 PM, Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> wrote: > > From: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com> > > Signed-off-by: Zeng Zhaoxiu <zhaoxiu.zeng@gmail.com> Please explain why do you think we should make this change. Btw, the original code used is_power_of_2, but we thought hweight is more explicit so it was adopted. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 04/10] omap_hwspinlock: Replace "hweight_long(i & 0xf) != 1" with "!is_power_of_2(i & 0xf)" Zhaoxiu Zeng <zhaoxiu.zeng@gmail.com> - 2015-12-06 11:40 +0100
Re: [PATCH 04/10] omap_hwspinlock: Replace "hweight_long(i & 0xf) != 1" with "!is_power_of_2(i & 0xf)" Ohad Ben-Cohen <ohad@wizery.com> - 2015-12-07 12:10 +0100
Re: [PATCH 04/10] omap_hwspinlock: Replace "hweight_long(i & 0xf) != 1" with "!is_power_of_2(i & 0xf)" "zhaoxiu.zeng" <zhaoxiu.zeng@gmail.com> - 2015-12-07 16:10 +0100
Re: [PATCH 04/10] omap_hwspinlock: Replace "hweight_long(i & 0xf) != 1" with "!is_power_of_2(i & 0xf)" Ohad Ben-Cohen <ohad@wizery.com> - 2015-12-07 17:20 +0100
csiph-web