Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1284982

Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero

From Rusty Russell <rusty@rustcorp.com.au>
Newsgroups linux.kernel
Subject Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero
Date 2015-12-07 04:20 +0100
Message-ID <qCUvf-7qj-9@gated-at.bofh.it> (permalink)
References (1 earlier) <qBNPb-4Dl-7@gated-at.bofh.it> <qBOrT-56k-5@gated-at.bofh.it> <qBT8d-89d-11@gated-at.bofh.it> <qCxoZ-QM-7@gated-at.bofh.it> <qCLrX-1vZ-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Ingo Molnar <mingo@kernel.org> writes:
> * Rusty Russell <rusty@rustcorp.com.au> wrote:
>> I don't think there are great answers here.  But adding more subtle zeroing 
>> semantics feels wrong, even if it will mostly Just Work.
>
> It's not subtle if the naming clearly reflects it (hence my suggestion to rename 
> the API) - and the status quo for on-stack allocations is zeroing anyway, so it's 
> not a big jump...

True, but we already have zalloc_cpumask_var() though if we want that?

It probably makes sense to just switch everyone to that and get rid of
the non-z one?

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is  zero Steven Rostedt <rostedt@goodmis.org> - 2015-12-03 23:30 +0100
  Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Rusty Russell <rusty@rustcorp.com.au> - 2015-12-04 03:00 +0100
    Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Steven Rostedt <rostedt@goodmis.org> - 2015-12-04 03:40 +0100
      Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Ingo Molnar <mingo@kernel.org> - 2015-12-04 08:40 +0100
        Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Rusty Russell <rusty@rustcorp.com.au> - 2015-12-06 03:40 +0100
          Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Ingo Molnar <mingo@kernel.org> - 2015-12-06 18:40 +0100
            Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Rusty Russell <rusty@rustcorp.com.au> - 2015-12-07 04:20 +0100
              Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Ingo Molnar <mingo@kernel.org> - 2015-12-07 09:30 +0100

csiph-web