Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1283610

Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero

Show all headers | View raw

* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Fri, 04 Dec 2015 12:05:12 +1030
> Rusty Russell <rusty@rustcorp.com.au> wrote:
> 
> > This is clever, but I would advise against such subtle code.  We will never be 
> > able to remove this code once it is in.
> > 
> > Would suggest making the non-CPUMASK_OFFSTACK stubs write garbage into the 
> > cpumasks instead, iff !(flags & __GFP_ZERO).
>
> I actually thought of the same thing, but thought it was a bit harsh. If others 
> think that's a better solution, then I'll submit a patch to do that.

That just makes things more fragile - 'garbage' will spread the breakage, and if 
the breakage is subtle, it will spread subtle breakage.

So why not use a kzmalloc_node() [equivalent] call instead of kmalloc_node(), to 
make sure it's all zeroed instead of uninitialized?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is  zero Steven Rostedt <rostedt@goodmis.org> - 2015-12-03 23:30 +0100
  Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Rusty Russell <rusty@rustcorp.com.au> - 2015-12-04 03:00 +0100
    Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Steven Rostedt <rostedt@goodmis.org> - 2015-12-04 03:40 +0100
      Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Ingo Molnar <mingo@kernel.org> - 2015-12-04 08:40 +0100
        Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Rusty Russell <rusty@rustcorp.com.au> - 2015-12-06 03:40 +0100
          Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Ingo Molnar <mingo@kernel.org> - 2015-12-06 18:40 +0100
            Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero Rusty Russell <rusty@rustcorp.com.au> - 2015-12-07 04:20 +0100
              Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr  is zero Ingo Molnar <mingo@kernel.org> - 2015-12-07 09:30 +0100

csiph-web