Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification
Date	Mon, 07 Dec 2015 02:10:01 +0100
Message-ID	<qCStr-64w-7@gated-at.bofh.it> (permalink)
References	<qC6oO-8cc-11@gated-at.bofh.it> <qCnSF-3my-7@gated-at.bofh.it> <qCo2l-3pR-5@gated-at.bofh.it>
X-Original-To	Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>
User-Agent	KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; )
MIME-Version	1.0
Content-Transfer-Encoding	7Bit
Content-Type	text/plain; charset="utf-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Andy Shevchenko <andy.shevchenko@gmail.com>, "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>, Vinod Koul <vinod.koul@intel.com>, dmaengine <dmaengine@vger.kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Jarkko Nikula <jarkko.nikula@linux.intel.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Mika Westerberg <mika.westerberg@linux.intel.com>
X-Original-Date	Mon, 07 Dec 2015 02:31:25 +0100
X-Original-Message-ID	<3490462.ARevfiQkZD@vostro.rjw.lan>
X-Original-References	<1449265765-9393-1-git-send-email-andriy.shevchenko@linux.intel.com> <CAHp75VfaqaXVx+Y4zvLXHJ9KR0zmZo+fzU36-CToioHYKYReyg@mail.gmail.com> <20151205163622.GA2237@kroah.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1284949

Show key headers only | View raw

On Saturday, December 05, 2015 08:36:22 AM Greg Kroah-Hartman wrote:
> On Sat, Dec 05, 2015 at 06:24:05PM +0200, Andy Shevchenko wrote:
> > On Sat, Dec 5, 2015 at 6:14 PM, Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > On Fri, Dec 04, 2015 at 11:49:17PM +0200, Andy Shevchenko wrote:
> > >> The users of BUS_NOTIFY_BIND_DRIVER have no chance to do any cleanup in case of
> > >> a probe failure. In the result there might be problems, such as some resources
> > >> that had been allocated will continue to be allocated and therefore lead to a
> > >> resource leak.
> > >>
> > >> Introduce a new notification to inform the subscriber that ->probe() failed. Do
> > >> the same in case of failed device_bind_driver() call.
> > >
> > > Ugh, I hate all these notifiers, but this one does make sense...
> > 
> > Yeah, I'm not a fan of them either.
> > 
> > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > You meant Acked-by, didn't you?
> 
> Either works :)

Thanks!

Andy, what about if I put patches [1-6/9] into my queue for v4.5 now and
the remaining ones will wait for Vinod to comment?

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-04 22:50 +0100
  Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-05 17:20 +0100
    Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-05 17:30 +0100
      Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-05 17:40 +0100
        Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-07 02:10 +0100
          Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-07 12:00 +0100
            Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-07 23:30 +0100
              Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-08 14:40 +0100
                Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-08 15:00 +0100
                Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-09 02:00 +0100
                Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-09 02:20 +0100
              Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Thomas Gleixner <tglx@linutronix.de> - 2015-12-08 14:40 +0100

csiph-web