Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification
Date	2015-12-05 17:40 +0100
Message-ID	<qCo2l-3pR-5@gated-at.bofh.it> (permalink)
References	<qC6oO-8cc-11@gated-at.bofh.it> <qC6oO-8cc-21@gated-at.bofh.it> <qCnIZ-3jk-1@gated-at.bofh.it> <qCnSF-3my-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Dec 05, 2015 at 06:24:05PM +0200, Andy Shevchenko wrote:
> On Sat, Dec 5, 2015 at 6:14 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > On Fri, Dec 04, 2015 at 11:49:17PM +0200, Andy Shevchenko wrote:
> >> The users of BUS_NOTIFY_BIND_DRIVER have no chance to do any cleanup in case of
> >> a probe failure. In the result there might be problems, such as some resources
> >> that had been allocated will continue to be allocated and therefore lead to a
> >> resource leak.
> >>
> >> Introduce a new notification to inform the subscriber that ->probe() failed. Do
> >> the same in case of failed device_bind_driver() call.
> >
> > Ugh, I hate all these notifiers, but this one does make sense...
> 
> Yeah, I'm not a fan of them either.
> 
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> You meant Acked-by, didn't you?

Either works :)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-04 22:50 +0100
  Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-05 17:20 +0100
    Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-05 17:30 +0100
      Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2015-12-05 17:40 +0100
        Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-07 02:10 +0100
          Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2015-12-07 12:00 +0100
            Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-07 23:30 +0100
              Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-08 14:40 +0100
                Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-08 15:00 +0100
                Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-12-09 02:00 +0100
                Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND notification Andy Shevchenko <andy.shevchenko@gmail.com> - 2015-12-09 02:20 +0100
              Re: [PATCH v3 1/9] device core: add BUS_NOTIFY_DRIVER_NOT_BOUND  notification Thomas Gleixner <tglx@linutronix.de> - 2015-12-08 14:40 +0100

csiph-web