Re: Asterisk deadlocks since Kernel 4.1

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: Asterisk deadlocks since Kernel 4.1
Date	2015-12-07 02:30 +0100
Message-ID	<qCSMO-6cJ-5@gated-at.bofh.it> (permalink)
References	(5 earlier) <qBccV-5qs-11@gated-at.bofh.it> <qBe54-6Dh-25@gated-at.bofh.it> <qC3hh-6hF-41@gated-at.bofh.it> <qC9wm-1TA-15@gated-at.bofh.it> <qCOzw-3pN-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Dec 06, 2015 at 09:56:34PM +0100, Stefan Priebe wrote:
> Hi Herbert,
> 
> i think i found the issue in 4.1 with netlink. Somebody made a
> mistake while backporting or cherry-picking your patch "netlink: Fix
> autobind race condition that leads to zero port ID" to 4.1.
> 
> It misses a goto in 4.1.
> 
> This goto is missing in 4.1:
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 4017e12..f15c001 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -1132,7 +1132,6 @@ static int netlink_insert(struct sock *sk, u32 portid)
>                 if (err == -EEXIST)
>                         err = -EADDRINUSE;
>                 sock_put(sk);
> -               goto err;
>         }
> 
>         /* We need to ensure that the socket is hashed and visible. */
> 
> Can you please confirm, that this is not correct and might cause
> those issues.

Well spotted! Yes this would be a fatal error and can cause the
problems you guys are seeing.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2015-12-02 10:50 +0100
  Re: Asterisk deadlocks since Kernel 4.1 Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-12-02 12:50 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Philipp Hahn <pmhahn@pmhahn.de> - 2015-12-02 19:00 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2015-12-03 09:30 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe <s.priebe@profihost.ag> - 2015-12-04 19:30 +0100
      Re: Asterisk deadlocks since Kernel 4.1 Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-05 02:10 +0100
        Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe <s.priebe@profihost.ag> - 2015-12-06 22:00 +0100
          Re: Asterisk deadlocks since Kernel 4.1 Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-07 02:30 +0100
            Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe - Profihost AG <s.priebe@profihost.ag> - 2015-12-07 08:00 +0100
              netlink: Add missing goto statement to netlink_insert Herbert Xu <herbert@gondor.apana.org.au> - 2015-12-08 07:20 +0100
                Re: netlink: Add missing goto statement to netlink_insert David Miller <davem@davemloft.net> - 2015-12-08 17:30 +0100
                Re: netlink: Add missing goto statement to netlink_insert Greg KH <greg@kroah.com> - 2015-12-09 04:40 +0100
          Re: Asterisk deadlocks since Kernel 4.1 Philipp Hahn <pmhahn@pmhahn.de> - 2015-12-07 08:50 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Philipp Matthias Hahn <pmhahn@pmhahn.de> - 2015-12-05 15:20 +0100
      Re: Asterisk deadlocks since Kernel 4.1 Stefan Priebe <s.priebe@profihost.ag> - 2015-12-05 16:40 +0100
  Re: Asterisk deadlocks since Kernel 4.1 Philipp Hahn <pmhahn@pmhahn.de> - 2015-12-02 19:00 +0100
    Re: Asterisk deadlocks since Kernel 4.1 Hannes Frederic Sowa <hannes@stressinduktion.org> - 2015-12-02 19:30 +0100

csiph-web